Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(234)

Unified Diff: webrtc/pc/channelmanager_unittest.cc

Issue 2492473002: Stop caching supported codecs in WebRtcVideoEngine2 (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/pc/channelmanager_unittest.cc
diff --git a/webrtc/pc/channelmanager_unittest.cc b/webrtc/pc/channelmanager_unittest.cc
index 174d064b0543b0da6fd8cd10ddf4a02910d79723..34b347b3ff78c32f663922a3ac5b91c391243ee0 100644
--- a/webrtc/pc/channelmanager_unittest.cc
+++ b/webrtc/pc/channelmanager_unittest.cc
@@ -173,17 +173,17 @@ TEST_F(ChannelManagerTest, SetVideoRtxEnabled) {
const VideoCodec rtx_codec(96, "rtx");
// By default RTX is disabled.
- cm_->GetSupportedVideoCodecs(&codecs);
+ codecs = cm_->GetSupportedVideoCodecs();
EXPECT_FALSE(ContainsMatchingCodec(codecs, rtx_codec));
// Enable and check.
EXPECT_TRUE(cm_->SetVideoRtxEnabled(true));
- cm_->GetSupportedVideoCodecs(&codecs);
+ codecs = cm_->GetSupportedVideoCodecs();
EXPECT_TRUE(ContainsMatchingCodec(codecs, rtx_codec));
// Disable and check.
EXPECT_TRUE(cm_->SetVideoRtxEnabled(false));
- cm_->GetSupportedVideoCodecs(&codecs);
+ codecs = cm_->GetSupportedVideoCodecs();
EXPECT_FALSE(ContainsMatchingCodec(codecs, rtx_codec));
// Cannot toggle rtx after initialization.
@@ -194,7 +194,7 @@ TEST_F(ChannelManagerTest, SetVideoRtxEnabled) {
// Can set again after terminate.
cm_->Terminate();
EXPECT_TRUE(cm_->SetVideoRtxEnabled(true));
- cm_->GetSupportedVideoCodecs(&codecs);
+ codecs = cm_->GetSupportedVideoCodecs();
EXPECT_TRUE(ContainsMatchingCodec(codecs, rtx_codec));
}

Powered by Google App Engine
This is Rietveld 408576698