Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(336)

Issue 2491933002: Revert of Declare VideoCodec.codec_specific_info private (Closed)

Created:
4 years, 1 month ago by hta-webrtc
Modified:
4 years, 1 month ago
CC:
webrtc-reviews_webrtc.org, interface-changes_webrtc.org, video-team_agora.io, yujie_mao (webrtc), zhengzhonghou_agora.io, stefan-webrtc, tterriberry_mozilla.com, qiang.lu, niklas.enbom, peah-webrtc, mflodman
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Declare VideoCodec.codec_specific_info private (patchset #5 id:80001 of https://codereview.webrtc.org/2452963002/ ) Reason for revert: Broke a google3 build Original issue's description: > Declare VideoCodec.codec_specific_info private > > This completes the privatization of the codec specific > information in VideoCodec. > > BUG=webrtc:6603 > > Committed: https://crrev.com/792738640234d81c916ac4458ac72286cb2548a4 > Cr-Commit-Position: refs/heads/master@{#15013} TBR=tommi@chromium.org,magjed@chromium.org,tommi@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:6603 Committed: https://crrev.com/7fe6db91d99cf6d43874651bcca56092cf869e2f Cr-Commit-Position: refs/heads/master@{#15027}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -34 lines) Patch
M webrtc/api/android/jni/androidmediaencoder_jni.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/common_types.h View 1 chunk +3 lines, -2 lines 0 comments Download
M webrtc/common_types.cc View 1 chunk +7 lines, -7 lines 0 comments Download
M webrtc/config.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M webrtc/video/vie_encoder.cc View 3 chunks +27 lines, -21 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
hta-webrtc
Created Revert of Declare VideoCodec.codec_specific_info private
4 years, 1 month ago (2016-11-10 16:36:40 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2491933002/1
4 years, 1 month ago (2016-11-10 16:36:46 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-10 16:37:04 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/7fe6db91d99cf6d43874651bcca56092cf869e2f Cr-Commit-Position: refs/heads/master@{#15027}
4 years, 1 month ago (2016-11-10 16:37:09 UTC) #7
hta-webrtc
4 years, 1 month ago (2016-11-11 13:44:37 UTC) #8
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.webrtc.org/2494683006/ by hta@webrtc.org.

The reason for reverting is: Relanding, now that downstream issues have been
fixed.
.

Powered by Google App Engine
This is Rietveld 408576698