Revert of Issue 2434073003: Extract bitrate allocation ...

Revert of Issue 2434073003: Extract bitrate allocation ... (patchset #4 id:60001 of https://codereview.webrtc.org/2488833004/ )

Reason for revert:
Seems to be causing flakiness in perf test:
FullStackTest.ScreenshareSlidesVP8_2TL_LossyNet

Original issue's description:
> Reland of Issue 2434073003: Extract bitrate allocation ...
>
> This is a reland of https://codereview.webrtc.org/2434073003/ including
> some fixes for failing test cases.
>
> Original description:
>
> Extract bitrate allocation of spatial/temporal layers out of codec impl.
>
> This CL makes a number of intervowen changes:
>
> * Add BitrateAllocation struct, that contains a codec independent view
>   of how the target bitrate is distributed over spatial and temporal
>   layers.
>
> * Adds the BitrateAllocator interface, which takes a bitrate and frame
>   rate and produces a BitrateAllocation.
>
> * A default (non layered) implementation is added, and
>   SimulcastRateAllocator is extended to fully handle VP8 allocation.
>   This includes capturing TemporalLayer instances created by the
>   encoder.
>
> * ViEEncoder now owns both the bitrate allocator and the temporal layer
>   factories for VP8. This allows allocation to happen fully outside of
>   the encoder implementation.
>
> This refactoring will make it possible for ViEEncoder to signal the
> full picture of target bitrates to the RTCP module.
>
> BUG=webrtc:6301
>
> Committed: https://crrev.com/647bf43dcb2fd16fccf276bd94dc4400728bb405
> Cr-Commit-Position: refs/heads/master@{#15023}

TBR=mflodman@webrtc.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=webrtc:6301
Committed: https://crrev.com/1369c83b42be2e082ca124605106e436f3c56d84
Cr-Commit-Position: refs/heads/master@{#15026}

[sprang_webrtc, 2016-11-10 16:30:10]

The CQ bit was checked by sprang@webrtc.org

[sprang_webrtc, 2016-11-10 16:30:10]

Created Revert of Issue 2434073003: Extract bitrate allocation ...

[commit-bot: I haz the power, 2016-11-10 16:30:16]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-11-10 16:30:36]

Description was changed from

==========
Revert of Issue 2434073003: Extract bitrate allocation ... (patchset #4 id:60001
of https://codereview.webrtc.org/2488833004/ )

Reason for revert:
Seems to be causing flakiness in perf test:
FullStackTest.ScreenshareSlidesVP8_2TL_LossyNet

Original issue's description:
> Reland of Issue 2434073003: Extract bitrate allocation ...
> 
> This is a reland of https://codereview.webrtc.org/2434073003/ including
> some fixes for failing test cases.
> 
> Original description:
> 
> Extract bitrate allocation of spatial/temporal layers out of codec impl.
> 
> This CL makes a number of intervowen changes:
> 
> * Add BitrateAllocation struct, that contains a codec independent view
>   of how the target bitrate is distributed over spatial and temporal
>   layers.
> 
> * Adds the BitrateAllocator interface, which takes a bitrate and frame
>   rate and produces a BitrateAllocation.
> 
> * A default (non layered) implementation is added, and
>   SimulcastRateAllocator is extended to fully handle VP8 allocation.
>   This includes capturing TemporalLayer instances created by the
>   encoder.
> 
> * ViEEncoder now owns both the bitrate allocator and the temporal layer
>   factories for VP8. This allows allocation to happen fully outside of
>   the encoder implementation.
> 
> This refactoring will make it possible for ViEEncoder to signal the
> full picture of target bitrates to the RTCP module.
> 
> BUG=webrtc:6301
> 
> Committed: https://crrev.com/647bf43dcb2fd16fccf276bd94dc4400728bb405
> Cr-Commit-Position: refs/heads/master@{#15023}

TBR=mflodman@webrtc.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=webrtc:6301
==========

to

==========
Revert of Issue 2434073003: Extract bitrate allocation ... (patchset #4 id:60001
of https://codereview.webrtc.org/2488833004/ )

Reason for revert:
Seems to be causing flakiness in perf test:
FullStackTest.ScreenshareSlidesVP8_2TL_LossyNet

Original issue's description:
> Reland of Issue 2434073003: Extract bitrate allocation ...
> 
> This is a reland of https://codereview.webrtc.org/2434073003/ including
> some fixes for failing test cases.
> 
> Original description:
> 
> Extract bitrate allocation of spatial/temporal layers out of codec impl.
> 
> This CL makes a number of intervowen changes:
> 
> * Add BitrateAllocation struct, that contains a codec independent view
>   of how the target bitrate is distributed over spatial and temporal
>   layers.
> 
> * Adds the BitrateAllocator interface, which takes a bitrate and frame
>   rate and produces a BitrateAllocation.
> 
> * A default (non layered) implementation is added, and
>   SimulcastRateAllocator is extended to fully handle VP8 allocation.
>   This includes capturing TemporalLayer instances created by the
>   encoder.
> 
> * ViEEncoder now owns both the bitrate allocator and the temporal layer
>   factories for VP8. This allows allocation to happen fully outside of
>   the encoder implementation.
> 
> This refactoring will make it possible for ViEEncoder to signal the
> full picture of target bitrates to the RTCP module.
> 
> BUG=webrtc:6301
> 
> Committed: https://crrev.com/647bf43dcb2fd16fccf276bd94dc4400728bb405
> Cr-Commit-Position: refs/heads/master@{#15023}

TBR=mflodman@webrtc.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=webrtc:6301
==========

[commit-bot: I haz the power, 2016-11-10 16:30:37]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-11-10 16:30:46]

Description was changed from

==========
Revert of Issue 2434073003: Extract bitrate allocation ... (patchset #4 id:60001
of https://codereview.webrtc.org/2488833004/ )

Reason for revert:
Seems to be causing flakiness in perf test:
FullStackTest.ScreenshareSlidesVP8_2TL_LossyNet

Original issue's description:
> Reland of Issue 2434073003: Extract bitrate allocation ...
> 
> This is a reland of https://codereview.webrtc.org/2434073003/ including
> some fixes for failing test cases.
> 
> Original description:
> 
> Extract bitrate allocation of spatial/temporal layers out of codec impl.
> 
> This CL makes a number of intervowen changes:
> 
> * Add BitrateAllocation struct, that contains a codec independent view
>   of how the target bitrate is distributed over spatial and temporal
>   layers.
> 
> * Adds the BitrateAllocator interface, which takes a bitrate and frame
>   rate and produces a BitrateAllocation.
> 
> * A default (non layered) implementation is added, and
>   SimulcastRateAllocator is extended to fully handle VP8 allocation.
>   This includes capturing TemporalLayer instances created by the
>   encoder.
> 
> * ViEEncoder now owns both the bitrate allocator and the temporal layer
>   factories for VP8. This allows allocation to happen fully outside of
>   the encoder implementation.
> 
> This refactoring will make it possible for ViEEncoder to signal the
> full picture of target bitrates to the RTCP module.
> 
> BUG=webrtc:6301
> 
> Committed: https://crrev.com/647bf43dcb2fd16fccf276bd94dc4400728bb405
> Cr-Commit-Position: refs/heads/master@{#15023}

TBR=mflodman@webrtc.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=webrtc:6301
==========

to

==========
Revert of Issue 2434073003: Extract bitrate allocation ... (patchset #4 id:60001
of https://codereview.webrtc.org/2488833004/ )

Reason for revert:
Seems to be causing flakiness in perf test:
FullStackTest.ScreenshareSlidesVP8_2TL_LossyNet

Original issue's description:
> Reland of Issue 2434073003: Extract bitrate allocation ...
>
> This is a reland of https://codereview.webrtc.org/2434073003/ including
> some fixes for failing test cases.
>
> Original description:
>
> Extract bitrate allocation of spatial/temporal layers out of codec impl.
>
> This CL makes a number of intervowen changes:
>
> * Add BitrateAllocation struct, that contains a codec independent view
>   of how the target bitrate is distributed over spatial and temporal
>   layers.
>
> * Adds the BitrateAllocator interface, which takes a bitrate and frame
>   rate and produces a BitrateAllocation.
>
> * A default (non layered) implementation is added, and
>   SimulcastRateAllocator is extended to fully handle VP8 allocation.
>   This includes capturing TemporalLayer instances created by the
>   encoder.
>
> * ViEEncoder now owns both the bitrate allocator and the temporal layer
>   factories for VP8. This allows allocation to happen fully outside of
>   the encoder implementation.
>
> This refactoring will make it possible for ViEEncoder to signal the
> full picture of target bitrates to the RTCP module.
>
> BUG=webrtc:6301
>
> Committed: https://crrev.com/647bf43dcb2fd16fccf276bd94dc4400728bb405
> Cr-Commit-Position: refs/heads/master@{#15023}

TBR=mflodman@webrtc.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=webrtc:6301

Committed: https://crrev.com/1369c83b42be2e082ca124605106e436f3c56d84
Cr-Commit-Position: refs/heads/master@{#15026}
==========

[commit-bot: I haz the power, 2016-11-10 16:30:47]

Patchset 1 (id:??) landed as
https://crrev.com/1369c83b42be2e082ca124605106e436f3c56d84
Cr-Commit-Position: refs/heads/master@{#15026}