Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(232)

Issue 2490143002: Use bitcode by default for ios framework build. (Closed)

Created:
4 years, 1 month ago by kthelgason
Modified:
4 years, 1 month ago
Reviewers:
kjellander_webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, qiang.lu, niklas.enbom, yujie_mao (webrtc), peah-webrtc
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Use bitcode by default for ios framework build. BUG=webrtc:5085 NOTRY=true Committed: https://crrev.com/5ec208fc987e05d0d219add54bfe78855479a727 Cr-Commit-Position: refs/heads/master@{#15011}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -7 lines) Patch
M webrtc/build/ios/build_ios_libs.sh View 3 chunks +6 lines, -7 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
kthelgason
Sorry for the unrelated refactoring that snuck in there!
4 years, 1 month ago (2016-11-10 08:34:28 UTC) #2
kjellander_webrtc
On 2016/11/10 08:34:28, kthelgason wrote: > Sorry for the unrelated refactoring that snuck in there! ...
4 years, 1 month ago (2016-11-10 08:39:17 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2490143002/1
4 years, 1 month ago (2016-11-10 09:03:50 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-10 09:13:46 UTC) #8
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/5ec208fc987e05d0d219add54bfe78855479a727 Cr-Commit-Position: refs/heads/master@{#15011}
4 years, 1 month ago (2016-11-10 09:13:57 UTC) #10
tkchin_webrtc
4 years, 1 month ago (2016-11-22 01:28:35 UTC) #11
Message was sent while issue was closed.
On 2016/11/10 09:13:57, commit-bot: I haz the power wrote:
> Patchset 1 (id:??) landed as
> https://crrev.com/5ec208fc987e05d0d219add54bfe78855479a727
> Cr-Commit-Position: refs/heads/master@{#15011}

Didn't see this. This should not be an unconfigurable default. Bitcode adds a
ton of debug symbols (think gigabyte).

Powered by Google App Engine
This is Rietveld 408576698