Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(239)

Issue 2490063002: Remove ScreenCapturer and WindowCapturer (Closed)

Created:
4 years, 1 month ago by Hzj_jie
Modified:
4 years, 1 month ago
Reviewers:
Sergey Ulanov, Jamie
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Remove ScreenCapturer and WindowCapturer This change removes ScreenCapturer and WindowCapturer from WebRTC. BUG=webrtc:6513 Committed: https://crrev.com/98903d2f5ef420adb343358824b94731b4a00b38 Cr-Commit-Position: refs/heads/master@{#15033}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+141 lines, -1148 lines) Patch
M webrtc/modules/BUILD.gn View 2 chunks +1 line, -3 lines 0 comments Download
M webrtc/modules/desktop_capture/BUILD.gn View 6 chunks +1 line, -13 lines 0 comments Download
M webrtc/modules/desktop_capture/cropping_window_capturer.h View 1 chunk +3 lines, -4 lines 0 comments Download
M webrtc/modules/desktop_capture/cropping_window_capturer.cc View 2 chunks +4 lines, -5 lines 0 comments Download
M webrtc/modules/desktop_capture/cropping_window_capturer_win.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/modules/desktop_capture/desktop_and_cursor_composer_unittest.cc View 1 chunk +2 lines, -3 lines 0 comments Download
D webrtc/modules/desktop_capture/desktop_capture.gni View 1 chunk +0 lines, -11 lines 0 comments Download
M webrtc/modules/desktop_capture/desktop_capture.gypi View 3 chunks +0 lines, -4 lines 0 comments Download
M webrtc/modules/desktop_capture/desktop_capturer.cc View 2 chunks +0 lines, -6 lines 0 comments Download
M webrtc/modules/desktop_capture/desktop_capturer_differ_wrapper_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M webrtc/modules/desktop_capture/fake_desktop_capturer.h View 2 chunks +11 lines, -54 lines 0 comments Download
A webrtc/modules/desktop_capture/fake_desktop_capturer.cc View 1 chunk +70 lines, -0 lines 0 comments Download
D webrtc/modules/desktop_capture/fake_screen_capturer.h View 1 chunk +0 lines, -35 lines 0 comments Download
D webrtc/modules/desktop_capture/fake_screen_capturer.cc View 1 chunk +0 lines, -34 lines 0 comments Download
M webrtc/modules/desktop_capture/mouse_cursor_monitor_unittest.cc View 1 chunk +2 lines, -3 lines 0 comments Download
D webrtc/modules/desktop_capture/screen_capturer.h View 1 chunk +0 lines, -75 lines 0 comments Download
D webrtc/modules/desktop_capture/screen_capturer.cc View 1 chunk +0 lines, -53 lines 0 comments Download
D webrtc/modules/desktop_capture/screen_capturer_differ_wrapper.h View 1 chunk +0 lines, -59 lines 0 comments Download
D webrtc/modules/desktop_capture/screen_capturer_differ_wrapper.cc View 1 chunk +0 lines, -216 lines 0 comments Download
D webrtc/modules/desktop_capture/screen_capturer_differ_wrapper_unittest.cc View 1 chunk +0 lines, -291 lines 0 comments Download
M webrtc/modules/desktop_capture/screen_capturer_integration_test.cc View 1 chunk +4 lines, -5 lines 0 comments Download
M webrtc/modules/desktop_capture/screen_capturer_mac.mm View 7 chunks +11 lines, -35 lines 0 comments Download
M webrtc/modules/desktop_capture/screen_capturer_mac_unittest.cc View 1 chunk +1 line, -2 lines 0 comments Download
M webrtc/modules/desktop_capture/screen_capturer_mock_objects.h View 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/modules/desktop_capture/screen_capturer_null.cc View 1 chunk +1 line, -6 lines 0 comments Download
M webrtc/modules/desktop_capture/screen_capturer_unittest.cc View 1 chunk +3 lines, -4 lines 0 comments Download
M webrtc/modules/desktop_capture/screen_capturer_win.cc View 2 chunks +1 line, -24 lines 0 comments Download
M webrtc/modules/desktop_capture/screen_capturer_x11.cc View 4 chunks +4 lines, -23 lines 0 comments Download
M webrtc/modules/desktop_capture/win/screen_capturer_win_directx.h View 2 chunks +2 lines, -3 lines 0 comments Download
M webrtc/modules/desktop_capture/win/screen_capturer_win_gdi.h View 2 chunks +2 lines, -3 lines 0 comments Download
M webrtc/modules/desktop_capture/win/screen_capturer_win_magnifier.h View 2 chunks +2 lines, -2 lines 0 comments Download
D webrtc/modules/desktop_capture/window_capturer.h View 1 chunk +0 lines, -68 lines 0 comments Download
D webrtc/modules/desktop_capture/window_capturer.cc View 1 chunk +0 lines, -61 lines 0 comments Download
M webrtc/modules/desktop_capture/window_capturer_mac.mm View 4 chunks +2 lines, -8 lines 0 comments Download
M webrtc/modules/desktop_capture/window_capturer_null.cc View 2 chunks +2 lines, -8 lines 0 comments Download
M webrtc/modules/desktop_capture/window_capturer_unittest.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M webrtc/modules/desktop_capture/window_capturer_win.cc View 4 chunks +2 lines, -8 lines 0 comments Download
M webrtc/modules/desktop_capture/window_capturer_x11.cc View 4 chunks +2 lines, -10 lines 0 comments Download

Messages

Total messages: 44 (33 generated)
Hzj_jie
4 years, 1 month ago (2016-11-10 05:27:58 UTC) #25
Sergey Ulanov
Can you please run this change on chromium trybots to make sure it doesn't break ...
4 years, 1 month ago (2016-11-10 20:30:45 UTC) #26
Hzj_jie
On 2016/11/10 20:30:45, Sergey Ulanov wrote: > Can you please run this change on chromium ...
4 years, 1 month ago (2016-11-10 21:10:49 UTC) #29
Sergey Ulanov
lgtm
4 years, 1 month ago (2016-11-10 23:05:57 UTC) #30
Hzj_jie
On 2016/11/10 23:05:57, Sergey Ulanov wrote: > lgtm It looks like the patch cannot work ...
4 years, 1 month ago (2016-11-11 01:58:02 UTC) #31
Hzj_jie
On 2016/11/11 01:58:02, Hzj_jie wrote: > On 2016/11/10 23:05:57, Sergey Ulanov wrote: > > lgtm ...
4 years, 1 month ago (2016-11-11 05:25:50 UTC) #33
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2490063002/80001
4 years, 1 month ago (2016-11-11 05:27:21 UTC) #35
commit-bot: I haz the power
Try jobs failed on following builders: bot1 on master.tryserver.chromium.linux (JOB_FAILED, no build URL) bot2 on ...
4 years, 1 month ago (2016-11-11 05:27:49 UTC) #37
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2490063002/80001
4 years, 1 month ago (2016-11-11 05:48:16 UTC) #40
commit-bot: I haz the power
Committed patchset #1 (id:80001)
4 years, 1 month ago (2016-11-11 05:57:15 UTC) #42
commit-bot: I haz the power
4 years, 1 month ago (2016-11-11 05:57:26 UTC) #44
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/98903d2f5ef420adb343358824b94731b4a00b38
Cr-Commit-Position: refs/heads/master@{#15033}

Powered by Google App Engine
This is Rietveld 408576698