Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(324)

Issue 2489943004: Remove references of ScreenCapturer and WindowCapturer (Closed)

Created:
4 years, 1 month ago by Hzj_jie
Modified:
4 years, 1 month ago
Reviewers:
Sergey Ulanov, Jamie
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Remove references of ScreenCapturer and WindowCapturer This change removes references of ScreenCapturer and WindowCapturer from WebRTC. So after this change, ScreenCapturer and WindowCapturer classes can be entirely removed. BUG=webrtc:6513 Committed: https://crrev.com/3045589e5f09be70daa13ea65b297a4e2b83611a Cr-Commit-Position: refs/heads/master@{#15006}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -23 lines) Patch
M webrtc/modules/desktop_capture/cropping_window_capturer.h View 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/modules/desktop_capture/cropping_window_capturer.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M webrtc/modules/desktop_capture/mouse_cursor_monitor_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/modules/desktop_capture/screen_capturer_mac_unittest.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M webrtc/modules/desktop_capture/screen_capturer_unittest.cc View 3 chunks +11 lines, -11 lines 0 comments Download
M webrtc/modules/desktop_capture/window_capturer_unittest.cc View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 23 (18 generated)
Hzj_jie
4 years, 1 month ago (2016-11-09 23:04:05 UTC) #14
Sergey Ulanov
lgtm
4 years, 1 month ago (2016-11-09 23:23:50 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2489943004/40001
4 years, 1 month ago (2016-11-10 00:36:14 UTC) #19
commit-bot: I haz the power
Committed patchset #1 (id:40001)
4 years, 1 month ago (2016-11-10 00:37:51 UTC) #20
commit-bot: I haz the power
4 years, 1 month ago (2016-11-10 00:38:06 UTC) #22
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3045589e5f09be70daa13ea65b297a4e2b83611a
Cr-Commit-Position: refs/heads/master@{#15006}

Powered by Google App Engine
This is Rietveld 408576698