Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(448)

Issue 2489693002: Don't copy loop variables when we don't have to (Closed)

Created:
4 years, 1 month ago by kwiberg-webrtc
Modified:
4 years, 1 month ago
Reviewers:
hbos
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Don't copy loop variables when we don't have to This was suggested by clang-tidy. BUG=none Committed: https://crrev.com/1b35d4cdf1804e245bcc975e80a5cf78b87b8cd4 Cr-Commit-Position: refs/heads/master@{#15018}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M webrtc/api/rtcstatscollector.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
kwiberg-webrtc
4 years, 1 month ago (2016-11-08 21:11:51 UTC) #4
hbos
lgtm
4 years, 1 month ago (2016-11-10 12:31:21 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2489693002/1
4 years, 1 month ago (2016-11-10 12:31:38 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-10 13:15:41 UTC) #10
commit-bot: I haz the power
4 years, 1 month ago (2016-11-10 13:15:46 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1b35d4cdf1804e245bcc975e80a5cf78b87b8cd4
Cr-Commit-Position: refs/heads/master@{#15018}

Powered by Google App Engine
This is Rietveld 408576698