Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issue 2489173004: Revert of Stop caching supported codecs in WebRtcVideoEngine2 (Closed)

Created:
4 years, 1 month ago by magjed_webrtc
Modified:
4 years, 1 month ago
Reviewers:
tommi
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, the sun
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Stop caching supported codecs in WebRtcVideoEngine2 (patchset #1 id:1 of https://codereview.webrtc.org/2492473002/ ) Reason for revert: This CL probably broke Chromium FYI. Original issue's description: > Stop caching supported codecs in WebRtcVideoEngine2 > > We currently cache the result of GetSupportedCodecs in a member variable > |video_codecs_| in WebRtcVideoEngine2. This means we need to keep > |video_codecs_| and the result of GetSupportedCodecs in sync, which is > error prone. It's simpler to just call GetSupportedCodecs when we need > it, and we actually end up making fewer calls, so it's faster as well. > This CL also returns all std::vectors by-value instead of by-ref. Move > semantic together with in-place filtering of codecs actually end up with > fewer copies, and it's also simpler to not return references. > > BUG=webrtc:6337 > > Committed: https://crrev.com/9f71ec5a3e3175751f4475b126cfda89767363f2 > Cr-Commit-Position: refs/heads/master@{#15007} TBR=tommi@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:6337 Committed: https://crrev.com/3cf8ece95400d1ffe2160eab8238c83f044d4b8c Cr-Commit-Position: refs/heads/master@{#15014}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -21 lines) Patch
M webrtc/media/base/mediaengine.h View 2 chunks +2 lines, -2 lines 0 comments Download
M webrtc/media/engine/webrtcvideoengine2.h View 2 chunks +3 lines, -1 line 0 comments Download
M webrtc/media/engine/webrtcvideoengine2.cc View 3 chunks +5 lines, -2 lines 0 comments Download
M webrtc/pc/channelmanager.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/pc/channelmanager.cc View 2 chunks +12 lines, -10 lines 0 comments Download
M webrtc/pc/channelmanager_unittest.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M webrtc/pc/mediasession.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
magjed_webrtc
Created Revert of Stop caching supported codecs in WebRtcVideoEngine2
4 years, 1 month ago (2016-11-10 11:36:42 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2489173004/1
4 years, 1 month ago (2016-11-10 11:36:48 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-10 11:36:56 UTC) #4
commit-bot: I haz the power
4 years, 1 month ago (2016-11-10 11:37:06 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3cf8ece95400d1ffe2160eab8238c83f044d4b8c
Cr-Commit-Position: refs/heads/master@{#15014}

Powered by Google App Engine
This is Rietveld 408576698