Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Side by Side Diff: webrtc/sdk/objc/Framework/Classes/RTCFieldTrials.mm

Issue 2488863002: iOS: Fix improved BWE field trial. (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright 2016 The WebRTC Project Authors. All rights reserved. 2 * Copyright 2016 The WebRTC Project Authors. All rights reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
11 #import "WebRTC/RTCFieldTrials.h" 11 #import "WebRTC/RTCFieldTrials.h"
12 12
13 #include <memory> 13 #include <memory>
14 14
15 #import "WebRTC/RTCLogging.h" 15 #import "WebRTC/RTCLogging.h"
16 16
17 #include "webrtc/system_wrappers/include/field_trial_default.h" 17 #include "webrtc/system_wrappers/include/field_trial_default.h"
18 18
19 static NSString * const kRTCEnableImprovedBitrateEstimateString = 19 static NSString * const kRTCEnableImprovedBitrateEstimateString =
20 @"WebRTC-ImprovedBitrateEstimate/Enabled/"; 20 @"WebRTC-ImprovedBitrateEstimate/Enabled/";
21 21
22 static std::unique_ptr<char[]> gFieldTrialInitString; 22 static std::unique_ptr<char[]> gFieldTrialInitString;
23 23
24 void RTCInitFieldTrials(RTCFieldTrialOptions options) { 24 void RTCInitFieldTrials(RTCFieldTrialOptions options) {
25 NSMutableString *fieldTrialInitString = [NSMutableString string]; 25 NSMutableString *fieldTrialInitString = [NSMutableString string];
26 size_t len = fieldTrialInitString.length + 1;
27 gFieldTrialInitString.reset(new char[len]);
28
29 if (options & RTCFieldTrialOptionsImprovedBitrateEstimate) { 26 if (options & RTCFieldTrialOptionsImprovedBitrateEstimate) {
30 [fieldTrialInitString appendString:kRTCEnableImprovedBitrateEstimateString]; 27 [fieldTrialInitString appendString:kRTCEnableImprovedBitrateEstimateString];
31 } 28 }
32 29 size_t len = fieldTrialInitString.length + 1;
30 gFieldTrialInitString.reset(new char[len]);
33 if (![fieldTrialInitString getCString:gFieldTrialInitString.get() 31 if (![fieldTrialInitString getCString:gFieldTrialInitString.get()
34 maxLength:len 32 maxLength:len
35 encoding:NSUTF8StringEncoding]) { 33 encoding:NSUTF8StringEncoding]) {
36 RTCLogError(@"Failed to convert field trial string."); 34 RTCLogError(@"Failed to convert field trial string.");
37 return; 35 return;
38 } 36 }
39 webrtc::field_trial::InitFieldTrialsFromString(gFieldTrialInitString.get()); 37 webrtc::field_trial::InitFieldTrialsFromString(gFieldTrialInitString.get());
40 } 38 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698