Add screenshare support to AppRTCMobile.

Add screenshare support to AppRTCMobile.

BUG=webrtc:6674
Committed: https://crrev.com/ccf10219cd47c297c1f06f3b42cc1f7df68a24d3
Cr-Commit-Position: refs/heads/master@{#15003}

[sakal, 2016-11-08 09:06:23]

Patchset #1 (id:1) has been deleted

[sakal, 2016-11-08 09:06:37]

Description was changed from

==========
Add screenshare support to AppRTCMobile.

BUG=webrtc:6674
==========

to

==========
Add screenshare support to AppRTCMobile.

BUG=webrtc:6674
==========

[sakal, 2016-11-08 09:06:37]

sakal@webrtc.org changed reviewers:
+ magjed@webrtc.org

[sakal, 2016-11-08 09:06:43]

PTAL

[magjed_webrtc, 2016-11-09 09:07:53]

https://codereview.webrtc.org/2488643002/diff/20001/webrtc/examples/androidap...
File webrtc/examples/androidapp/res/xml/preferences.xml (right):

https://codereview.webrtc.org/2488643002/diff/20001/webrtc/examples/androidap...
webrtc/examples/androidapp/res/xml/preferences.xml:13: <CheckBoxPreference
Maybe we should have a ListPreference instead with title VideoSource and then
 * Camera1
 * Camera2
 * ScreenCapture
 * FileCapture (TODO)
What do you think?

https://codereview.webrtc.org/2488643002/diff/20001/webrtc/examples/androidap...
File webrtc/examples/androidapp/src/org/appspot/apprtc/CallActivity.java
(right):

https://codereview.webrtc.org/2488643002/diff/20001/webrtc/examples/androidap...
webrtc/examples/androidapp/src/org/appspot/apprtc/CallActivity.java:380: if
(peerConnectionClient != null && !screencaptureEnabled) {
Comment why we do this, e.g. to allow the user to show his screen while doing
something outside AppRTCMobile.

[sakal, 2016-11-09 14:53:56]

Patchset #2 (id:40001) has been deleted

[sakal, 2016-11-09 14:56:00]

I also made changes to default to a correct capturing format. Maximum capturing
format is legacy from the constraint days and is not needed anymore.

https://codereview.webrtc.org/2488643002/diff/20001/webrtc/examples/androidap...
File webrtc/examples/androidapp/res/xml/preferences.xml (right):

https://codereview.webrtc.org/2488643002/diff/20001/webrtc/examples/androidap...
webrtc/examples/androidapp/res/xml/preferences.xml:13: <CheckBoxPreference
On 2016/11/09 09:07:53, magjed_webrtc wrote:
> Maybe we should have a ListPreference instead with title VideoSource and then
>  * Camera1
>  * Camera2
>  * ScreenCapture
>  * FileCapture (TODO)
> What do you think?

Sgtm but let's do that in a follow-up.

https://codereview.webrtc.org/2488643002/diff/20001/webrtc/examples/androidap...
File webrtc/examples/androidapp/src/org/appspot/apprtc/CallActivity.java
(right):

https://codereview.webrtc.org/2488643002/diff/20001/webrtc/examples/androidap...
webrtc/examples/androidapp/src/org/appspot/apprtc/CallActivity.java:380: if
(peerConnectionClient != null && !screencaptureEnabled) {
On 2016/11/09 09:07:53, magjed_webrtc wrote:
> Comment why we do this, e.g. to allow the user to show his screen while doing
> something outside AppRTCMobile.

Done.

[magjed_webrtc, 2016-11-09 15:02:56]

lgtm

[sakal, 2016-11-09 15:10:25]

The CQ bit was checked by sakal@webrtc.org

[commit-bot: I haz the power, 2016-11-09 15:10:37]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[sakal, 2016-11-09 15:11:56]

The CQ bit was unchecked by sakal@webrtc.org

[sakal, 2016-11-09 15:14:09]

The CQ bit was checked by sakal@webrtc.org

[commit-bot: I haz the power, 2016-11-09 15:14:14]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-11-09 15:37:30]

Description was changed from

==========
Add screenshare support to AppRTCMobile.

BUG=webrtc:6674
==========

to

==========
Add screenshare support to AppRTCMobile.

BUG=webrtc:6674
==========

[commit-bot: I haz the power, 2016-11-09 15:37:31]

Committed patchset #2 (id:60001)

[commit-bot: I haz the power, 2016-11-09 15:37:36]

Description was changed from

==========
Add screenshare support to AppRTCMobile.

BUG=webrtc:6674
==========

to

==========
Add screenshare support to AppRTCMobile.

BUG=webrtc:6674

Committed: https://crrev.com/ccf10219cd47c297c1f06f3b42cc1f7df68a24d3
Cr-Commit-Position: refs/heads/master@{#15003}
==========

[commit-bot: I haz the power, 2016-11-09 15:37:37]

Patchset 2 (id:??) landed as
https://crrev.com/ccf10219cd47c297c1f06f3b42cc1f7df68a24d3
Cr-Commit-Position: refs/heads/master@{#15003}