Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Issue 2487723004: Reland of Add a webrtc{en,de}coderfactory implementation for VideoToolbox (Closed)

Created:
4 years, 1 month ago by kthelgason
Modified:
4 years, 1 month ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, zhengzhonghou_agora.io, video-team_agora.io, stefan-webrtc, mflodman
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Reland of Add a webrtc{en,de}coderfactory implementation for VideoToolbox (patchset #1 id:1 of https://codereview.webrtc.org/2483273002/ ) Reason for revert: Fix gyp build Original issue's description: > Revert of Add a webrtc{en,de}coderfactory implementation for VideoToolbox (patchset #2 id:20001 of https://codereview.webrtc.org/2463313002/ ) > > Reason for revert: > Broke dependent project because the .gn changes weren't accompanied by corresponding .gyp changes. > > Original issue's description: > > Add a webrtc{en,de}coderfactory implementation for VideoToolbox > > > > This CL removes the coupling of the VideoToolbox h264 implementation > > to the generic h264 code. The files have been moved into sdb/obj/Framework > > and all dependency on them has been removed from the rest of WebRTC. > > We now add it as an external encoder via a factory supplied to the > > CreatePeerConnectionFactory call. This also brings the iOS implementation > > closer to what we do on Android for MediaCodec. > > > > BUG=webrtc:6619 > > > > Committed: https://crrev.com/6a5047dad31f14f53dd9f8bc1ecde19e1dede2e4 > > Cr-Commit-Position: refs/heads/master@{#14953} > > TBR=magjed@webrtc.org,stefan@webrtc.org,kthelgason@webrtc.org > BUG=webrtc:6619 > > Committed: https://crrev.com/d69ad84420d9c0e1c11450c352f6c92e7c9583f1 > Cr-Commit-Position: refs/heads/master@{#14985} R=magjed@webrtc.org TBR=kwiberg@webrtc.org, magjed@webrtc.org, stefan@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:6619 Committed: https://chromium.googlesource.com/external/webrtc/+/cbe743528848dc71e6bc15185002a634b78661c6

Patch Set 1 #

Patch Set 2 : fix gyp build #

Unified diffs Side-by-side diffs Delta from patch set Stats (+277 lines, -2009 lines) Patch
M webrtc/modules/BUILD.gn View 1 1 chunk +1 line, -4 lines 0 comments Download
M webrtc/modules/video_coding/BUILD.gn View 1 2 chunks +0 lines, -59 lines 0 comments Download
M webrtc/modules/video_coding/codecs/h264/h264.cc View 1 4 chunks +0 lines, -28 lines 0 comments Download
M webrtc/modules/video_coding/codecs/h264/h264.gypi View 2 chunks +0 lines, -45 lines 0 comments Download
D webrtc/modules/video_coding/codecs/h264/h264_objc.mm View 1 chunk +0 lines, -32 lines 0 comments Download
D webrtc/modules/video_coding/codecs/h264/h264_video_toolbox_decoder.h View 1 chunk +0 lines, -62 lines 0 comments Download
D webrtc/modules/video_coding/codecs/h264/h264_video_toolbox_decoder.cc View 1 chunk +0 lines, -281 lines 0 comments Download
D webrtc/modules/video_coding/codecs/h264/h264_video_toolbox_encoder.h View 1 chunk +0 lines, -98 lines 0 comments Download
D webrtc/modules/video_coding/codecs/h264/h264_video_toolbox_encoder.mm View 1 chunk +0 lines, -664 lines 0 comments Download
D webrtc/modules/video_coding/codecs/h264/h264_video_toolbox_nalu.h View 1 chunk +0 lines, -115 lines 0 comments Download
D webrtc/modules/video_coding/codecs/h264/h264_video_toolbox_nalu.cc View 1 chunk +0 lines, -369 lines 0 comments Download
D webrtc/modules/video_coding/codecs/h264/h264_video_toolbox_nalu_unittest.cc View 1 chunk +0 lines, -208 lines 0 comments Download
M webrtc/sdk/BUILD.gn View 1 6 chunks +60 lines, -3 lines 0 comments Download
M webrtc/sdk/DEPS View 1 1 chunk +2 lines, -0 lines 0 comments Download
M webrtc/sdk/objc/Framework/Classes/RTCPeerConnectionFactory.mm View 1 2 chunks +8 lines, -1 line 0 comments Download
A + webrtc/sdk/objc/Framework/Classes/h264_video_toolbox_decoder.h View 1 2 chunks +3 lines, -6 lines 0 comments Download
A + webrtc/sdk/objc/Framework/Classes/h264_video_toolbox_decoder.cc View 1 3 chunks +2 lines, -6 lines 0 comments Download
A + webrtc/sdk/objc/Framework/Classes/h264_video_toolbox_encoder.h View 1 3 chunks +3 lines, -6 lines 0 comments Download
A + webrtc/sdk/objc/Framework/Classes/h264_video_toolbox_encoder.mm View 1 3 chunks +2 lines, -6 lines 0 comments Download
A + webrtc/sdk/objc/Framework/Classes/h264_video_toolbox_nalu.h View 1 2 chunks +3 lines, -6 lines 0 comments Download
A + webrtc/sdk/objc/Framework/Classes/h264_video_toolbox_nalu.cc View 1 2 chunks +1 line, -5 lines 0 comments Download
A + webrtc/sdk/objc/Framework/Classes/h264_video_toolbox_nalu_unittest.cc View 1 2 chunks +1 line, -5 lines 0 comments Download
A webrtc/sdk/objc/Framework/Classes/videotoolboxvideocodecfactory.h View 1 chunk +50 lines, -0 lines 0 comments Download
A webrtc/sdk/objc/Framework/Classes/videotoolboxvideocodecfactory.cc View 1 chunk +103 lines, -0 lines 0 comments Download
M webrtc/sdk/sdk.gyp View 1 2 chunks +38 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
kthelgason
Created Reland of Add a webrtc{en,de}coderfactory implementation for VideoToolbox
4 years, 1 month ago (2016-11-08 19:40:47 UTC) #1
magjed_webrtc
lgtm
4 years, 1 month ago (2016-11-09 08:39:24 UTC) #3
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/cbe743528848dc71e6bc15185002a634b78661c6 Cr-Commit-Position: refs/heads/master@{#14992}
4 years, 1 month ago (2016-11-09 09:43:42 UTC) #6
kthelgason
Committed patchset #2 (id:280001) manually as cbe743528848dc71e6bc15185002a634b78661c6 (presubmit successful).
4 years, 1 month ago (2016-11-09 09:43:43 UTC) #7
kthelgason
4 years, 1 month ago (2016-11-09 09:58:32 UTC) #8
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:280001) has been created in
https://codereview.webrtc.org/2488663003/ by kthelgason@webrtc.org.

The reason for reverting is: Broke webrtc gyp build.

Powered by Google App Engine
This is Rietveld 408576698