Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(323)

Issue 2487723002: GN: Build tools and examples by default. (Closed)

Created:
4 years, 1 month ago by ehmaldonado_webrtc
Modified:
4 years, 1 month ago
CC:
webrtc-reviews_webrtc.org, qiang.lu, niklas.enbom, yujie_mao (webrtc), peah-webrtc
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

GN: Build tools and examples by default. BUG=webrtc:6412 TBR=kjellander@webrtc.org, charujain@webrtc.org NOTRY=True Committed: https://crrev.com/579729dd9e2b96284532615298820ddf46ea45eb Cr-Commit-Position: refs/heads/master@{#14982}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -5 lines) Patch
M BUILD.gn View 1 chunk +3 lines, -5 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2487723002/1
4 years, 1 month ago (2016-11-08 16:53:55 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-08 16:55:12 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/579729dd9e2b96284532615298820ddf46ea45eb Cr-Commit-Position: refs/heads/master@{#14982}
4 years, 1 month ago (2016-11-08 16:55:27 UTC) #7
kjellander_webrtc
4 years, 1 month ago (2016-11-08 17:45:08 UTC) #8
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698