Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issue 2487633002: Reland of Delete all use of cricket::VideoFrame and cricket::WebRtcVideoFrame. (Closed)

Created:
4 years, 1 month ago by nisse-webrtc
Modified:
4 years, 1 month ago
CC:
webrtc-reviews_webrtc.org, interface-changes_webrtc.org, yujie_mao (webrtc), tterriberry_mozilla.com, qiang.lu, niklas.enbom, peah-webrtc, the sun
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Reland of Delete all use of cricket::VideoFrame and cricket::WebRtcVideoFrame. (patchset #1 id:1 of https://codereview.webrtc.org/2471783002/ ) Reason for revert: Relanding after known downstream breakages have been fixed. Original issue's description: > Revert of Delete all use of cricket::VideoFrame and cricket::WebRtcVideoFrame. (patchset #7 id:120001 of https://codereview.webrtc.org/2383093002/ ) > > Reason for revert: > Breaks chrome, see https://build.chromium.org/p/chromium.webrtc.fyi/builders/Mac%20Builder/builds/19019/steps/compile/logs/stdio > > Analysis: Chrome uses cricket::VideoFrame, without explicitly including webrtc/media/base/videoframe.h, and breaks when that file is no longer included by any other webrtc headers. Will reland after updating Chrome. > > Original issue's description: > > Delete all use of cricket::VideoFrame and cricket::WebRtcVideoFrame. > > > > Replaced with webrtc::VideoFrame. > > > > TBR=mflodman@webrtc.org > > BUG=webrtc:5682 > > > > Committed: https://crrev.com/45c8b8940042bd2574c39920804ade8343cefdba > > Cr-Commit-Position: refs/heads/master@{#14885} > > TBR=perkj@webrtc.org,pthatcher@webrtc.org,tkchin@webrtc.org,mflodman@webrtc.org,stefan@webrtc.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=webrtc:5682 > > Committed: https://crrev.com/7341ab8e2505c9763d208e069bda269018357e7d > Cr-Commit-Position: refs/heads/master@{#14886} TBR=perkj@webrtc.org,pthatcher@webrtc.org,tkchin@webrtc.org,mflodman@webrtc.org,stefan@webrtc.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=webrtc:5682 Committed: https://crrev.com/acd935b5402a045e4038500e149903b18aa95226 Cr-Commit-Position: refs/heads/master@{#15039}

Patch Set 1 #

Patch Set 2 : Rebase, and update rtcstatscollector_unittest.cc. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+179 lines, -210 lines) Patch
M webrtc/api/android/java/src/org/webrtc/VideoRenderer.java View 1 1 chunk +1 line, -1 line 0 comments Download
M webrtc/api/android/jni/peerconnection_jni.cc View 1 7 chunks +9 lines, -10 lines 0 comments Download
M webrtc/api/androidvideotracksource.cc View 1 2 chunks +9 lines, -10 lines 0 comments Download
M webrtc/api/mediastreaminterface.h View 1 3 chunks +5 lines, -6 lines 0 comments Download
M webrtc/api/mediastreamtrackproxy.h View 1 1 chunk +4 lines, -6 lines 0 comments Download
M webrtc/api/rtcstatscollector_unittest.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/api/videocapturertracksource_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/api/videosourceproxy.h View 1 1 chunk +2 lines, -4 lines 0 comments Download
M webrtc/api/videotrack.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/api/videotrack.cc View 1 2 chunks +3 lines, -5 lines 0 comments Download
M webrtc/api/videotrack_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/api/videotracksource.h View 1 2 chunks +4 lines, -5 lines 0 comments Download
M webrtc/api/videotracksource.cc View 1 3 chunks +3 lines, -4 lines 0 comments Download
M webrtc/examples/peerconnection/client/linux/main_wnd.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/examples/peerconnection/client/linux/main_wnd.cc View 1 2 chunks +4 lines, -8 lines 0 comments Download
M webrtc/examples/peerconnection/client/main_wnd.h View 1 3 chunks +3 lines, -3 lines 0 comments Download
M webrtc/examples/peerconnection/client/main_wnd.cc View 1 2 chunks +4 lines, -8 lines 0 comments Download
M webrtc/media/base/adaptedvideotracksource.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
M webrtc/media/base/adaptedvideotracksource.cc View 1 4 chunks +4 lines, -4 lines 0 comments Download
M webrtc/media/base/fakemediaengine.h View 1 4 chunks +6 lines, -6 lines 0 comments Download
M webrtc/media/base/fakevideocapturer.h View 1 2 chunks +4 lines, -3 lines 0 comments Download
M webrtc/media/base/fakevideorenderer.h View 1 3 chunks +4 lines, -4 lines 0 comments Download
M webrtc/media/base/mediachannel.h View 1 3 chunks +3 lines, -5 lines 0 comments Download
M webrtc/media/base/testutils.h View 1 3 chunks +6 lines, -2 lines 0 comments Download
M webrtc/media/base/testutils.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M webrtc/media/base/videoadapter_unittest.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M webrtc/media/base/videobroadcaster.h View 1 3 chunks +5 lines, -6 lines 0 comments Download
M webrtc/media/base/videobroadcaster.cc View 1 4 chunks +4 lines, -4 lines 0 comments Download
M webrtc/media/base/videobroadcaster_unittest.cc View 1 4 chunks +6 lines, -7 lines 0 comments Download
M webrtc/media/base/videocapturer.h View 1 4 chunks +9 lines, -4 lines 0 comments Download
M webrtc/media/base/videocapturer.cc View 1 4 chunks +5 lines, -5 lines 0 comments Download
M webrtc/media/base/videosourcebase.h View 1 chunk +7 lines, -8 lines 0 comments Download
M webrtc/media/base/videosourcebase.cc View 1 3 chunks +3 lines, -4 lines 0 comments Download
M webrtc/media/devices/gtkvideorenderer.h View 1 chunk +5 lines, -5 lines 0 comments Download
M webrtc/media/devices/gtkvideorenderer.cc View 1 3 chunks +9 lines, -12 lines 0 comments Download
M webrtc/media/engine/webrtcvideocapturer.h View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/media/engine/webrtcvideocapturer.cc View 1 2 chunks +1 line, -5 lines 0 comments Download
M webrtc/media/engine/webrtcvideoengine2.h View 1 9 chunks +14 lines, -17 lines 0 comments Download
M webrtc/media/engine/webrtcvideoengine2.cc View 1 6 chunks +9 lines, -8 lines 0 comments Download
M webrtc/pc/channel.h View 1 2 chunks +3 lines, -2 lines 0 comments Download
M webrtc/pc/channel.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M webrtc/sdk/objc/Framework/Classes/RTCVideoFrame+Private.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/sdk/objc/Framework/Classes/RTCVideoRendererAdapter.mm View 1 2 chunks +3 lines, -5 lines 0 comments Download
M webrtc/sdk/objc/Framework/Classes/RTCVideoRendererAdapter+Private.h View 1 1 chunk +1 line, -1 line 0 comments Download
M webrtc/sdk/objc/Framework/Headers/WebRTC/RTCVideoFrame.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/video_frame.h View 1 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 14 (5 generated)
nisse-webrtc
Created Reland of Delete all use of cricket::VideoFrame and cricket::WebRtcVideoFrame.
4 years, 1 month ago (2016-11-08 07:52:59 UTC) #1
tkchin_webrtc
On 2016/11/08 07:52:59, nisse-webrtc wrote: > Created Reland of Delete all use of cricket::VideoFrame and ...
4 years, 1 month ago (2016-11-08 23:48:24 UTC) #2
perkj_webrtc
On 2016/11/08 23:48:24, tkchin_webrtc wrote: > On 2016/11/08 07:52:59, nisse-webrtc wrote: > > Created Reland ...
4 years, 1 month ago (2016-11-09 06:40:19 UTC) #3
stefan-webrtc
lgtm
4 years, 1 month ago (2016-11-09 18:01:53 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2487633002/1
4 years, 1 month ago (2016-11-11 10:15:20 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: ios32_sim_dbg on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/ios32_sim_dbg/builds/12414) ios64_sim_dbg on master.tryserver.webrtc (JOB_FAILED, ...
4 years, 1 month ago (2016-11-11 10:18:09 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2487633002/300001
4 years, 1 month ago (2016-11-11 11:26:27 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:300001)
4 years, 1 month ago (2016-11-11 11:55:17 UTC) #12
commit-bot: I haz the power
4 years, 1 month ago (2016-11-11 11:55:26 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/acd935b5402a045e4038500e149903b18aa95226
Cr-Commit-Position: refs/heads/master@{#15039}

Powered by Google App Engine
This is Rietveld 408576698