Add UMA histogram for Echo likelihood.

Add UMA histogram for Echo likelihood.

The likelihood is logged as a percentage, with 100 bins in the histogram.

BUG=webrtc:6525
Committed: https://crrev.com/ef6cbae756986c92cfe324065866ece2046498b5
Cr-Commit-Position: refs/heads/master@{#15025}

[ivoc, 2016-11-09 15:49:48]

Description was changed from

==========
Add UMA histogram for Echo likelihood.

The likelihood is logged as a percentage, with 100 bins in the histogram.

BUG=webrtc:6525
==========

to

==========
Add UMA histogram for Echo likelihood.

The likelihood is logged as a percentage, with 100 bins in the histogram.

BUG=webrtc:6525
==========

[ivoc, 2016-11-09 15:49:48]

ivoc@webrtc.org changed reviewers:
+ henrik.lundin@webrtc.org

[ivoc, 2016-11-09 15:52:41]

Hi Henrik, Please have a look at this small CL to add a UMA histogram for echo
likelihood. This will call the macro every 10ms, which should be fine from a
computational point of view, because the UMA logging code just updates the
histogram in memory (so this is almost the same as keeping a local histogram in
the class).

[hlundin-webrtc, 2016-11-09 20:01:26]

LGTM with optional comment.

https://codereview.webrtc.org/2487243002/diff/1/webrtc/modules/audio_processi...
File webrtc/modules/audio_processing/residual_echo_detector.cc (right):

https://codereview.webrtc.org/2487243002/diff/1/webrtc/modules/audio_processi...
webrtc/modules/audio_processing/residual_echo_detector.cc:107: echo_percentage,
0, 100, kNumberOfHistogramBins);
I'm not convinced that kNumberOfHistogramBins grants improved readability.
Consider "100 /* number of bins */".

[ivoc, 2016-11-10 15:13:47]

Thanks!

https://codereview.webrtc.org/2487243002/diff/1/webrtc/modules/audio_processi...
File webrtc/modules/audio_processing/residual_echo_detector.cc (right):

https://codereview.webrtc.org/2487243002/diff/1/webrtc/modules/audio_processi...
webrtc/modules/audio_processing/residual_echo_detector.cc:107: echo_percentage,
0, 100, kNumberOfHistogramBins);
On 2016/11/09 20:01:26, hlundin-webrtc wrote:
> I'm not convinced that kNumberOfHistogramBins grants improved readability.
> Consider "100 /* number of bins */".

Done.

[ivoc, 2016-11-10 15:13:57]

The CQ bit was checked by ivoc@webrtc.org

[ivoc, 2016-11-10 15:13:57]

The patchset sent to the CQ was uploaded after l-g-t-m from
henrik.lundin@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2487243002/#ps20001 (title:
"Removed constant for number of histogram bins.")

[commit-bot: I haz the power, 2016-11-10 15:14:06]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-11-10 16:21:05]

Description was changed from

==========
Add UMA histogram for Echo likelihood.

The likelihood is logged as a percentage, with 100 bins in the histogram.

BUG=webrtc:6525
==========

to

==========
Add UMA histogram for Echo likelihood.

The likelihood is logged as a percentage, with 100 bins in the histogram.

BUG=webrtc:6525
==========

[commit-bot: I haz the power, 2016-11-10 16:21:06]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-11-10 16:21:53]

Description was changed from

==========
Add UMA histogram for Echo likelihood.

The likelihood is logged as a percentage, with 100 bins in the histogram.

BUG=webrtc:6525
==========

to

==========
Add UMA histogram for Echo likelihood.

The likelihood is logged as a percentage, with 100 bins in the histogram.

BUG=webrtc:6525

Committed: https://crrev.com/ef6cbae756986c92cfe324065866ece2046498b5
Cr-Commit-Position: refs/heads/master@{#15025}
==========

[commit-bot: I haz the power, 2016-11-10 16:21:54]

Patchset 2 (id:??) landed as
https://crrev.com/ef6cbae756986c92cfe324065866ece2046498b5
Cr-Commit-Position: refs/heads/master@{#15025}