Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(154)

Issue 2486753002: GN: Don't build tests by default. (Closed)

Created:
4 years, 1 month ago by ehmaldonado_webrtc
Modified:
4 years, 1 month ago
CC:
webrtc-reviews_webrtc.org, qiang.lu, niklas.enbom, yujie_mao (webrtc), peah-webrtc
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

GN: Don't build tests by default. BUG=webrtc:6412 R=kjellander@webrtc.org, charujain@webrtc.org NOTRY=True Committed: https://crrev.com/37d7a22af94c02cb37ad17d58f68f3361da9f74f Cr-Commit-Position: refs/heads/master@{#14979}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -3 lines) Patch
M BUILD.gn View 1 chunk +9 lines, -3 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
ehmaldonado_webrtc
So it looks like //:default always includes the tests which we might not want, for ...
4 years, 1 month ago (2016-11-08 13:51:26 UTC) #1
kjellander_webrtc
lgtm
4 years, 1 month ago (2016-11-08 13:57:33 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2486753002/1
4 years, 1 month ago (2016-11-08 14:32:46 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-08 14:34:24 UTC) #7
commit-bot: I haz the power
4 years, 1 month ago (2016-11-08 14:34:28 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/37d7a22af94c02cb37ad17d58f68f3361da9f74f
Cr-Commit-Position: refs/heads/master@{#14979}

Powered by Google App Engine
This is Rietveld 408576698