Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(200)

Issue 2486743002: Remove GetPreferredTryMasters from PRESUBMIT. (Closed)

Created:
4 years, 1 month ago by tandrii(chromium)
Modified:
4 years, 1 month ago
Reviewers:
kjellander_webrtc
CC:
webrtc-reviews_webrtc.org, qiang.lu, niklas.enbom, yujie_mao (webrtc), peah-webrtc
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Remove GetPreferredTryMasters from PRESUBMIT. git cl try will then trigger CQ dry run, achieving even better result, because PRESUBMIT will be run as well. R=kjellander@webrtc.org BUG=663320 NOTRY=True

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -25 lines) Patch
M PRESUBMIT.py View 1 chunk +0 lines, -25 lines 0 comments Download

Messages

Total messages: 15 (9 generated)
kjellander_webrtc
lgtm
4 years, 1 month ago (2016-11-08 13:43:39 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2486743002/1
4 years, 1 month ago (2016-11-08 13:43:54 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2486743002/1
4 years, 1 month ago (2016-11-08 13:44:20 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: presubmit on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/9926)
4 years, 1 month ago (2016-11-08 13:48:21 UTC) #13
kjellander_webrtc
Replaced by https://codereview.webrtc.org/2489523003/ Closing this one.
4 years, 1 month ago (2016-11-08 13:54:39 UTC) #14
tandrii(chromium)
4 years, 1 month ago (2016-11-08 13:54:58 UTC) #15
Message was sent while issue was closed.
abandoned in favor of https://codereview.webrtc.org/2489523003/

Powered by Google App Engine
This is Rietveld 408576698