Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2486553002:
Disable ScreenCapturerIntegrationTests because of flaky (Closed)
DescriptionDisable ScreenCapturerIntegrationTests because of flaky
ScreenCapturerIntegrationTests are still flaky on Windows.
BUG=webrtc:6666
TBR=kjellander@webrtc.org
Committed: https://crrev.com/6f601afcf403adee91d4eae743902ca30f111a64
Cr-Commit-Position: refs/heads/master@{#14961}
Patch Set 1 #
Messages
Total messages: 20 (11 generated)
Description was changed from ========== Disable ScreenCapturerIntegrationTests because of flaky. BUG=webrtc:6666 ========== to ========== Disable ScreenCapturerIntegrationTests because of flaky. BUG=webrtc:6666 ==========
zijiehe@chromium.org changed reviewers: + kjellander@webrtc.org
Disable ScreenCapturerIntegrationTests because of flaky ScreenCapturerIntegrationTests are still flaky on Windows. Bug=webrtc:6666
Description was changed from ========== Disable ScreenCapturerIntegrationTests because of flaky. BUG=webrtc:6666 ========== to ========== Disable ScreenCapturerIntegrationTests because of flaky ScreenCapturerIntegrationTests are still flaky on Windows. Bug=webrtc:6666 ==========
Description was changed from ========== Disable ScreenCapturerIntegrationTests because of flaky ScreenCapturerIntegrationTests are still flaky on Windows. Bug=webrtc:6666 ========== to ========== Disable ScreenCapturerIntegrationTests because of flaky ScreenCapturerIntegrationTests are still flaky on Windows. Bug=webrtc:6666 TBR=kjellander@webrtc.org ==========
Considering this is a serious issue to suffer webrtc developers, and this change is fairly simple and safe. I will go ahead to submit the change if I have not got LGTM in one hour.
sergeyu@chromium.org changed reviewers: + sergeyu@chromium.org
lgtm
The CQ bit was checked by zijiehe@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: presubmit on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/9893)
Description was changed from ========== Disable ScreenCapturerIntegrationTests because of flaky ScreenCapturerIntegrationTests are still flaky on Windows. Bug=webrtc:6666 TBR=kjellander@webrtc.org ========== to ========== Disable ScreenCapturerIntegrationTests because of flaky ScreenCapturerIntegrationTests are still flaky on Windows. BUG=webrtc:6666 TBR=kjellander@webrtc.org ==========
The CQ bit was checked by zijiehe@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
Message was sent while issue was closed.
Description was changed from ========== Disable ScreenCapturerIntegrationTests because of flaky ScreenCapturerIntegrationTests are still flaky on Windows. BUG=webrtc:6666 TBR=kjellander@webrtc.org ========== to ========== Disable ScreenCapturerIntegrationTests because of flaky ScreenCapturerIntegrationTests are still flaky on Windows. BUG=webrtc:6666 TBR=kjellander@webrtc.org ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Disable ScreenCapturerIntegrationTests because of flaky ScreenCapturerIntegrationTests are still flaky on Windows. BUG=webrtc:6666 TBR=kjellander@webrtc.org ========== to ========== Disable ScreenCapturerIntegrationTests because of flaky ScreenCapturerIntegrationTests are still flaky on Windows. BUG=webrtc:6666 TBR=kjellander@webrtc.org Committed: https://crrev.com/6f601afcf403adee91d4eae743902ca30f111a64 Cr-Commit-Position: refs/heads/master@{#14961} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/6f601afcf403adee91d4eae743902ca30f111a64 Cr-Commit-Position: refs/heads/master@{#14961}
Message was sent while issue was closed.
lgtm |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
