Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(394)

Issue 2485953002: Reenable P2P test case and remove outdated TODO (Closed)

Created:
4 years, 1 month ago by kthelgason
Modified:
4 years, 1 month ago
Reviewers:
perkj_webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Reenable P2P test case and remove outdated TODO BUG=None Committed: https://crrev.com/e239779a8bdfd1685a833eb73f4f937e30edbed7 Cr-Commit-Position: refs/heads/master@{#14981}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -5 lines) Patch
M webrtc/api/peerconnection_unittest.cc View 1 chunk +1 line, -5 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
kthelgason
Tiny fix, please take a look.
4 years, 1 month ago (2016-11-08 15:12:07 UTC) #2
perkj_webrtc
lgtm
4 years, 1 month ago (2016-11-08 16:18:24 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2485953002/1
4 years, 1 month ago (2016-11-08 16:18:32 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-08 16:19:51 UTC) #10
commit-bot: I haz the power
4 years, 1 month ago (2016-11-08 16:19:59 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e239779a8bdfd1685a833eb73f4f937e30edbed7
Cr-Commit-Position: refs/heads/master@{#14981}

Powered by Google App Engine
This is Rietveld 408576698