Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Issue 2485603002: Reinstated sctputils_unittest.cc (Closed)

Created:
4 years, 1 month ago by ossu
Modified:
4 years, 1 month ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Reinstated sctputils_unittest.cc As I was preparing to move some files from the api/ folder, I noticed that this file was not included in the BUILD.gn file. I've added it back in and updated it to compile and run successfully again. BUG=webrtc:5883 Committed: https://crrev.com/d4d2f6009e664cb6833bb1b1a3e8820c1bc44245 Cr-Commit-Position: refs/heads/master@{#14965}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -15 lines) Patch
M webrtc/api/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/api/sctputils_unittest.cc View 7 chunks +16 lines, -15 lines 2 comments Download

Messages

Total messages: 15 (9 generated)
ossu
The file's been dead for a while but you seem to be one of the ...
4 years, 1 month ago (2016-11-07 13:21:13 UTC) #5
Taylor Brandstetter
lgtm https://codereview.webrtc.org/2485603002/diff/1/webrtc/api/sctputils_unittest.cc File webrtc/api/sctputils_unittest.cc (left): https://codereview.webrtc.org/2485603002/diff/1/webrtc/api/sctputils_unittest.cc#oldcode153 webrtc/api/sctputils_unittest.cc:153: EXPECT_FALSE(webrtc::IsOpenMessage(open)); Wait, how was this ever passing?
4 years, 1 month ago (2016-11-07 20:06:20 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2485603002/1
4 years, 1 month ago (2016-11-08 09:55:51 UTC) #10
ossu
https://codereview.webrtc.org/2485603002/diff/1/webrtc/api/sctputils_unittest.cc File webrtc/api/sctputils_unittest.cc (left): https://codereview.webrtc.org/2485603002/diff/1/webrtc/api/sctputils_unittest.cc#oldcode153 webrtc/api/sctputils_unittest.cc:153: EXPECT_FALSE(webrtc::IsOpenMessage(open)); On 2016/11/07 20:06:20, Taylor Brandstetter wrote: > Wait, ...
4 years, 1 month ago (2016-11-08 09:55:56 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-08 10:05:35 UTC) #13
commit-bot: I haz the power
4 years, 1 month ago (2016-11-08 10:05:39 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d4d2f6009e664cb6833bb1b1a3e8820c1bc44245
Cr-Commit-Position: refs/heads/master@{#14965}

Powered by Google App Engine
This is Rietveld 408576698