Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(541)

Issue 2484913007: Use correct define in H264 end-to-end tests. (Closed)

Created:
4 years, 1 month ago by brandtr
Modified:
4 years, 1 month ago
Reviewers:
stefan-webrtc
CC:
webrtc-reviews_webrtc.org, video-team_agora.io, yujie_mao (webrtc), zhengzhonghou_agora.io, stefan-webrtc, tterriberry_mozilla.com, mflodman
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Use correct define in H264 end-to-end tests. Right now, the H264 end-to-end tests are not run on the bots. BUG=None Committed: https://crrev.com/445fb8fa4fd27b7e49b0555fc47b29d0d98f2496 Cr-Commit-Position: refs/heads/master@{#15062}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -4 lines) Patch
M webrtc/video/BUILD.gn View 1 chunk +3 lines, -0 lines 0 comments Download
M webrtc/video/end_to_end_tests.cc View 2 chunks +2 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
brandtr
Is this intentionally disabled, or just a mishap?
4 years, 1 month ago (2016-11-10 12:41:03 UTC) #2
stefan-webrtc
lgtm
4 years, 1 month ago (2016-11-14 10:32:13 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2484913007/1
4 years, 1 month ago (2016-11-14 11:30:55 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-14 12:11:25 UTC) #6
commit-bot: I haz the power
4 years, 1 month ago (2016-11-14 12:11:37 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/445fb8fa4fd27b7e49b0555fc47b29d0d98f2496
Cr-Commit-Position: refs/heads/master@{#15062}

Powered by Google App Engine
This is Rietveld 408576698