Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(230)

Issue 2484863009: Move VideoEncoderSoftwareFallbackWrapper from webrtc/video_encoder.h to webrtc/media/engine/ (Closed)

Created:
4 years, 1 month ago by magjed_webrtc
Modified:
4 years, 1 month ago
Reviewers:
stefan-webrtc
CC:
webrtc-reviews_webrtc.org, interface-changes_webrtc.org, video-team_agora.io, yujie_mao (webrtc), zhengzhonghou_agora.io, stefan-webrtc, tterriberry_mozilla.com, qiang.lu, niklas.enbom, peah-webrtc, the sun, mflodman
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Move VideoEncoderSoftwareFallbackWrapper from webrtc/video_encoder.h to webrtc/media/engine/ The class VideoEncoderSoftwareFallbackWrapper is an implementation detail of webrtc/media/engine/webrtcvideoengine2.cc and should not be directly under webrtc/video_encoder.h. The main purpose is to improve the dependency graph in WebRTC so that VideoEncoderSoftwareFallbackWrapper can depend on cricket::VideoCodec. The test for VideoEncoderSoftwareFallbackWrapper is also moved from webrtc/video/video_encoder_unittest.cc to webrtc/media/engine/videoencodersoftwarefallbackwrapper_unittest.cc. BUG=webrtc:6337 Committed: https://crrev.com/614d5b78d6b00609505ddf829a3e7dd3c3b267d6 Cr-Commit-Position: refs/heads/master@{#15085}

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -688 lines) Patch
M webrtc/media/BUILD.gn View 1 2 chunks +3 lines, -0 lines 0 comments Download
A + webrtc/media/engine/videoencodersoftwarefallbackwrapper.h View 1 3 chunks +7 lines, -142 lines 0 comments Download
A + webrtc/media/engine/videoencodersoftwarefallbackwrapper.cc View 1 2 chunks +3 lines, -52 lines 0 comments Download
A + webrtc/media/engine/videoencodersoftwarefallbackwrapper_unittest.cc View 1 1 chunk +3 lines, -1 line 0 comments Download
M webrtc/media/engine/webrtcvideoengine2.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/video/BUILD.gn View 1 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/video/video_encoder.cc View 1 1 chunk +0 lines, -148 lines 0 comments Download
D webrtc/video/video_encoder_unittest.cc View 1 1 chunk +0 lines, -293 lines 0 comments Download
M webrtc/video_encoder.h View 1 1 chunk +0 lines, -51 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 20 (14 generated)
magjed_webrtc
Stefan - please take a look.
4 years, 1 month ago (2016-11-09 22:02:52 UTC) #11
magjed_webrtc
Stefan - ping.
4 years, 1 month ago (2016-11-14 07:33:23 UTC) #13
stefan-webrtc
lgtm
4 years, 1 month ago (2016-11-15 09:03:38 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2484863009/40001
4 years, 1 month ago (2016-11-15 14:06:18 UTC) #16
commit-bot: I haz the power
Committed patchset #2 (id:40001)
4 years, 1 month ago (2016-11-15 14:30:57 UTC) #18
commit-bot: I haz the power
4 years, 1 month ago (2016-11-15 14:31:07 UTC) #20
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/614d5b78d6b00609505ddf829a3e7dd3c3b267d6
Cr-Commit-Position: refs/heads/master@{#15085}

Powered by Google App Engine
This is Rietveld 408576698