Expose bit rate property in ARDAppClient and set max bitrate for video RTCRtcSender.

Expose bit rate property in ARDAppClient and set max bitrate for video RTCRtcSender.

BUG=webrtc:6654
Committed: https://crrev.com/8c375dedb2d1a6b9b93a330ea225fcf6ef43dc73
Cr-Commit-Position: refs/heads/master@{#14977}

[daniela-webrtc, 2016-11-07 15:35:16]

denicija@webrtc.org changed reviewers:
+ kthelgason@webrtc.org, magjed@webrtc.org

[kthelgason, 2016-11-08 09:38:51]

This looks to me like the right approach, but I'm not at all familiar with this.
At least it mirrors what we do on the android side. Code looks good. lgtm!

[magjed_webrtc, 2016-11-08 12:52:46]

lgtm % nit

https://codereview.webrtc.org/2484733002/diff/1/webrtc/examples/objc/AppRTCMo...
File webrtc/examples/objc/AppRTCMobile/ARDAppClient.m (right):

https://codereview.webrtc.org/2484733002/diff/1/webrtc/examples/objc/AppRTCMo...
webrtc/examples/objc/AppRTCMobile/ARDAppClient.m:694: for
(RTCRtpEncodingParameters *encoding in parameters.encodings) {
nit: Can we just inline sender.parameters.encodings here?

[daniela-webrtc, 2016-11-08 13:28:35]

https://codereview.webrtc.org/2484733002/diff/1/webrtc/examples/objc/AppRTCMo...
File webrtc/examples/objc/AppRTCMobile/ARDAppClient.m (right):

https://codereview.webrtc.org/2484733002/diff/1/webrtc/examples/objc/AppRTCMo...
webrtc/examples/objc/AppRTCMobile/ARDAppClient.m:694: for
(RTCRtpEncodingParameters *encoding in parameters.encodings) {
On 2016/11/08 12:52:46, magjed_webrtc wrote:
> nit: Can we just inline sender.parameters.encodings here?

Done.

[daniela-webrtc, 2016-11-08 13:28:47]

The CQ bit was checked by denicija@webrtc.org

[daniela-webrtc, 2016-11-08 13:28:48]

The patchset sent to the CQ was uploaded after l-g-t-m from magjed@webrtc.org,
kthelgason@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2484733002/#ps40001 (title:
"Inline property instead of introducing local var")

[commit-bot: I haz the power, 2016-11-08 13:28:56]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-11-08 14:28:20]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-11-08 14:28:28]

Description was changed from

==========
Expose bit rate property in ARDAppClient and set max bitrate for video
RTCRtcSender.

BUG=webrtc:6654
==========

to

==========
Expose bit rate property in ARDAppClient and set max bitrate for video
RTCRtcSender.

BUG=webrtc:6654

Committed: https://crrev.com/8c375dedb2d1a6b9b93a330ea225fcf6ef43dc73
Cr-Commit-Position: refs/heads/master@{#14977}
==========

[commit-bot: I haz the power, 2016-11-08 14:28:29]

Patchset 3 (id:??) landed as
https://crrev.com/8c375dedb2d1a6b9b93a330ea225fcf6ef43dc73
Cr-Commit-Position: refs/heads/master@{#14977}