Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(730)

Side by Side Diff: webrtc/sdk/objc/Framework/Classes/h264_video_toolbox_encoder.mm

Issue 2484493002: Prepare iOS H264 HW encoder for High Profile (Closed)
Patch Set: Don't use default in switch Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2015 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2015 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 * 9 *
10 */ 10 */
11 11
12 #include "webrtc/sdk/objc/Framework/Classes/h264_video_toolbox_encoder.h" 12 #include "webrtc/sdk/objc/Framework/Classes/h264_video_toolbox_encoder.h"
13 13
14 #include <memory> 14 #include <memory>
15 #include <string> 15 #include <string>
16 #include <vector> 16 #include <vector>
17 17
18 #if defined(WEBRTC_IOS) 18 #if defined(WEBRTC_IOS)
19 #import "WebRTC/UIDevice+RTCDevice.h" 19 #import "WebRTC/UIDevice+RTCDevice.h"
20 #include "RTCUIApplication.h" 20 #include "RTCUIApplication.h"
21 #endif 21 #endif
22 #include "libyuv/convert_from.h" 22 #include "libyuv/convert_from.h"
23 #include "webrtc/base/checks.h" 23 #include "webrtc/base/checks.h"
24 #include "webrtc/base/logging.h" 24 #include "webrtc/base/logging.h"
25 #include "webrtc/common_video/h264/profile_level_id.h"
25 #include "webrtc/common_video/include/corevideo_frame_buffer.h" 26 #include "webrtc/common_video/include/corevideo_frame_buffer.h"
26 #include "webrtc/sdk/objc/Framework/Classes/h264_video_toolbox_nalu.h" 27 #include "webrtc/sdk/objc/Framework/Classes/h264_video_toolbox_nalu.h"
27 #include "webrtc/system_wrappers/include/clock.h" 28 #include "webrtc/system_wrappers/include/clock.h"
28 29
29 namespace internal { 30 namespace internal {
30 31
31 // The ratio between kVTCompressionPropertyKey_DataRateLimits and 32 // The ratio between kVTCompressionPropertyKey_DataRateLimits and
32 // kVTCompressionPropertyKey_AverageBitRate. The data rate limit is set higher 33 // kVTCompressionPropertyKey_AverageBitRate. The data rate limit is set higher
33 // than the average bit rate to avoid undershooting the target. 34 // than the average bit rate to avoid undershooting the target.
34 const float kLimitToAverageBitRateFactor = 1.5f; 35 const float kLimitToAverageBitRateFactor = 1.5f;
(...skipping 182 matching lines...) Expand 10 before | Expand all | Expand 10 after
217 CMSampleBufferRef sample_buffer) { 218 CMSampleBufferRef sample_buffer) {
218 std::unique_ptr<FrameEncodeParams> encode_params( 219 std::unique_ptr<FrameEncodeParams> encode_params(
219 reinterpret_cast<FrameEncodeParams*>(params)); 220 reinterpret_cast<FrameEncodeParams*>(params));
220 encode_params->encoder->OnEncodedFrame( 221 encode_params->encoder->OnEncodedFrame(
221 status, info_flags, sample_buffer, encode_params->codec_specific_info, 222 status, info_flags, sample_buffer, encode_params->codec_specific_info,
222 encode_params->width, encode_params->height, 223 encode_params->width, encode_params->height,
223 encode_params->render_time_ms, encode_params->timestamp, 224 encode_params->render_time_ms, encode_params->timestamp,
224 encode_params->rotation); 225 encode_params->rotation);
225 } 226 }
226 227
228 // Extract VideoToolbox profile out of the cricket::VideoCodec. If there is no
229 // specific VideoToolbox profile for the specified level, AutoLevel will be
230 // returned. The user must initialize the encoder with a resolution and
231 // framerate conforming to the selected H264 level regardless.
232 CFStringRef ExtractProfile(const cricket::VideoCodec& codec) {
233 const rtc::Optional<webrtc::H264::ProfileLevelId> profile_level_id =
234 webrtc::H264::ParseSdpProfileLevelId(codec.params);
235 RTC_DCHECK(profile_level_id);
236 switch (profile_level_id->profile) {
237 case webrtc::H264::kProfileConstrainedBaseline:
238 case webrtc::H264::kProfileBaseline:
239 switch (profile_level_id->level) {
240 case webrtc::H264::kLevel3:
241 return kVTProfileLevel_H264_Baseline_3_0;
242 case webrtc::H264::kLevel3_1:
243 return kVTProfileLevel_H264_Baseline_3_1;
244 case webrtc::H264::kLevel3_2:
245 return kVTProfileLevel_H264_Baseline_3_2;
246 case webrtc::H264::kLevel4:
247 return kVTProfileLevel_H264_Baseline_4_0;
248 case webrtc::H264::kLevel4_1:
249 return kVTProfileLevel_H264_Baseline_4_1;
250 case webrtc::H264::kLevel4_2:
251 return kVTProfileLevel_H264_Baseline_4_2;
252 case webrtc::H264::kLevel5:
253 return kVTProfileLevel_H264_Baseline_5_0;
254 case webrtc::H264::kLevel5_1:
255 return kVTProfileLevel_H264_Baseline_5_1;
256 case webrtc::H264::kLevel5_2:
257 return kVTProfileLevel_H264_Baseline_5_2;
258 case webrtc::H264::kLevel1:
259 case webrtc::H264::kLevel1_b:
260 case webrtc::H264::kLevel1_1:
261 case webrtc::H264::kLevel1_2:
262 case webrtc::H264::kLevel1_3:
263 case webrtc::H264::kLevel2:
264 case webrtc::H264::kLevel2_1:
265 case webrtc::H264::kLevel2_2:
266 return kVTProfileLevel_H264_Baseline_AutoLevel;
267 }
268
269 case webrtc::H264::kProfileMain:
270 switch (profile_level_id->level) {
271 case webrtc::H264::kLevel3:
272 return kVTProfileLevel_H264_Main_3_0;
273 case webrtc::H264::kLevel3_1:
274 return kVTProfileLevel_H264_Main_3_1;
275 case webrtc::H264::kLevel3_2:
276 return kVTProfileLevel_H264_Main_3_2;
277 case webrtc::H264::kLevel4:
278 return kVTProfileLevel_H264_Main_4_0;
279 case webrtc::H264::kLevel4_1:
280 return kVTProfileLevel_H264_Main_4_1;
281 case webrtc::H264::kLevel4_2:
282 return kVTProfileLevel_H264_Main_4_2;
283 case webrtc::H264::kLevel5:
284 return kVTProfileLevel_H264_Main_5_0;
285 case webrtc::H264::kLevel5_1:
286 return kVTProfileLevel_H264_Main_5_1;
287 case webrtc::H264::kLevel5_2:
288 return kVTProfileLevel_H264_Main_5_2;
289 case webrtc::H264::kLevel1:
290 case webrtc::H264::kLevel1_b:
291 case webrtc::H264::kLevel1_1:
292 case webrtc::H264::kLevel1_2:
293 case webrtc::H264::kLevel1_3:
294 case webrtc::H264::kLevel2:
295 case webrtc::H264::kLevel2_1:
296 case webrtc::H264::kLevel2_2:
297 return kVTProfileLevel_H264_Main_AutoLevel;
298 }
299
300 case webrtc::H264::kProfileConstrainedHigh:
301 case webrtc::H264::kProfileHigh:
302 switch (profile_level_id->level) {
303 case webrtc::H264::kLevel3:
304 return kVTProfileLevel_H264_High_3_0;
305 case webrtc::H264::kLevel3_1:
306 return kVTProfileLevel_H264_High_3_1;
307 case webrtc::H264::kLevel3_2:
308 return kVTProfileLevel_H264_High_3_2;
309 case webrtc::H264::kLevel4:
310 return kVTProfileLevel_H264_High_4_0;
311 case webrtc::H264::kLevel4_1:
312 return kVTProfileLevel_H264_High_4_1;
313 case webrtc::H264::kLevel4_2:
314 return kVTProfileLevel_H264_High_4_2;
315 case webrtc::H264::kLevel5:
316 return kVTProfileLevel_H264_High_5_0;
317 case webrtc::H264::kLevel5_1:
318 return kVTProfileLevel_H264_High_5_1;
319 case webrtc::H264::kLevel5_2:
320 return kVTProfileLevel_H264_High_5_2;
321 case webrtc::H264::kLevel1:
322 case webrtc::H264::kLevel1_b:
323 case webrtc::H264::kLevel1_1:
324 case webrtc::H264::kLevel1_2:
325 case webrtc::H264::kLevel1_3:
326 case webrtc::H264::kLevel2:
327 case webrtc::H264::kLevel2_1:
328 case webrtc::H264::kLevel2_2:
329 return kVTProfileLevel_H264_High_AutoLevel;
330 }
331 }
332 }
333
227 } // namespace internal 334 } // namespace internal
228 335
229 namespace webrtc { 336 namespace webrtc {
230 337
231 // .5 is set as a mininum to prevent overcompensating for large temporary 338 // .5 is set as a mininum to prevent overcompensating for large temporary
232 // overshoots. We don't want to degrade video quality too badly. 339 // overshoots. We don't want to degrade video quality too badly.
233 // .95 is set to prevent oscillations. When a lower bitrate is set on the 340 // .95 is set to prevent oscillations. When a lower bitrate is set on the
234 // encoder than previously set, its output seems to have a brief period of 341 // encoder than previously set, its output seems to have a brief period of
235 // drastically reduced bitrate, so we want to avoid that. In steady state 342 // drastically reduced bitrate, so we want to avoid that. In steady state
236 // conditions, 0.95 seems to give us better overall bitrate over long periods 343 // conditions, 0.95 seems to give us better overall bitrate over long periods
237 // of time. 344 // of time.
238 H264VideoToolboxEncoder::H264VideoToolboxEncoder() 345 H264VideoToolboxEncoder::H264VideoToolboxEncoder(
346 const cricket::VideoCodec& codec)
239 : callback_(nullptr), 347 : callback_(nullptr),
240 compression_session_(nullptr), 348 compression_session_(nullptr),
241 bitrate_adjuster_(Clock::GetRealTimeClock(), .5, .95) { 349 bitrate_adjuster_(Clock::GetRealTimeClock(), .5, .95),
350 profile_(internal::ExtractProfile(codec)) {
351 LOG(LS_INFO) << "Using profile " << internal::CFStringToString(profile_);
242 } 352 }
243 353
244 H264VideoToolboxEncoder::~H264VideoToolboxEncoder() { 354 H264VideoToolboxEncoder::~H264VideoToolboxEncoder() {
245 DestroyCompressionSession(); 355 DestroyCompressionSession();
246 } 356 }
247 357
248 int H264VideoToolboxEncoder::InitEncode(const VideoCodec* codec_settings, 358 int H264VideoToolboxEncoder::InitEncode(const VideoCodec* codec_settings,
249 int number_of_cores, 359 int number_of_cores,
250 size_t max_payload_size) { 360 size_t max_payload_size) {
251 RTC_DCHECK(codec_settings); 361 RTC_DCHECK(codec_settings);
(...skipping 237 matching lines...) Expand 10 before | Expand all | Expand 10 after
489 ConfigureCompressionSession(); 599 ConfigureCompressionSession();
490 return WEBRTC_VIDEO_CODEC_OK; 600 return WEBRTC_VIDEO_CODEC_OK;
491 } 601 }
492 602
493 void H264VideoToolboxEncoder::ConfigureCompressionSession() { 603 void H264VideoToolboxEncoder::ConfigureCompressionSession() {
494 RTC_DCHECK(compression_session_); 604 RTC_DCHECK(compression_session_);
495 internal::SetVTSessionProperty(compression_session_, 605 internal::SetVTSessionProperty(compression_session_,
496 kVTCompressionPropertyKey_RealTime, true); 606 kVTCompressionPropertyKey_RealTime, true);
497 internal::SetVTSessionProperty(compression_session_, 607 internal::SetVTSessionProperty(compression_session_,
498 kVTCompressionPropertyKey_ProfileLevel, 608 kVTCompressionPropertyKey_ProfileLevel,
499 kVTProfileLevel_H264_Baseline_AutoLevel); 609 profile_);
500 internal::SetVTSessionProperty(compression_session_, 610 internal::SetVTSessionProperty(compression_session_,
501 kVTCompressionPropertyKey_AllowFrameReordering, 611 kVTCompressionPropertyKey_AllowFrameReordering,
502 false); 612 false);
503 SetEncoderBitrateBps(target_bitrate_bps_); 613 SetEncoderBitrateBps(target_bitrate_bps_);
504 // TODO(tkchin): Look at entropy mode and colorspace matrices. 614 // TODO(tkchin): Look at entropy mode and colorspace matrices.
505 // TODO(tkchin): Investigate to see if there's any way to make this work. 615 // TODO(tkchin): Investigate to see if there's any way to make this work.
506 // May need it to interop with Android. Currently this call just fails. 616 // May need it to interop with Android. Currently this call just fails.
507 // On inspecting encoder output on iOS8, this value is set to 6. 617 // On inspecting encoder output on iOS8, this value is set to 6.
508 // internal::SetVTSessionProperty(compression_session_, 618 // internal::SetVTSessionProperty(compression_session_,
509 // kVTCompressionPropertyKey_MaxFrameDelayCount, 619 // kVTCompressionPropertyKey_MaxFrameDelayCount,
(...skipping 141 matching lines...) Expand 10 before | Expand all | Expand 10 after
651 EncodedImageCallback::Result result = 761 EncodedImageCallback::Result result =
652 callback_->OnEncodedImage(frame, &codec_specific_info, header.get()); 762 callback_->OnEncodedImage(frame, &codec_specific_info, header.get());
653 if (result.error != EncodedImageCallback::Result::OK) { 763 if (result.error != EncodedImageCallback::Result::OK) {
654 LOG(LS_ERROR) << "Encode callback failed: " << result.error; 764 LOG(LS_ERROR) << "Encode callback failed: " << result.error;
655 return; 765 return;
656 } 766 }
657 bitrate_adjuster_.Update(frame._size); 767 bitrate_adjuster_.Update(frame._size);
658 } 768 }
659 769
660 } // namespace webrtc 770 } // namespace webrtc
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698