Move smoothing filter to common audio.

webrtc/base/smoothing_filter.h

 /*
  *  Copyright (c) 2016 The WebRTC project authors. All Rights Reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  */
 
-#ifndef WEBRTC_MODULES_AUDIO_CODING_AUDIO_NETWORK_ADAPTOR_SMOOTHING_FILTER_H_
-#define WEBRTC_MODULES_AUDIO_CODING_AUDIO_NETWORK_ADAPTOR_SMOOTHING_FILTER_H_
+#ifndef WEBRTC_BASE_SMOOTHING_FILTER_H_
+#define WEBRTC_BASE_SMOOTHING_FILTER_H_
 
 #include "webrtc/base/constructormagic.h"
 #include "webrtc/base/exp_filter.h"
 #include "webrtc/base/optional.h"
 #include "webrtc/system_wrappers/include/clock.h"
 
 namespace webrtc {
 
 class SmoothingFilter {
  public:
   virtual ~SmoothingFilter() = default;

[the sun, 2016/11/09 10:02:59]

Virtual methods are not without cost. Is it truly necessary to add these just in
order to mock the class?

[michaelt, 2016/11/09 10:46:34]

Abstract classes should always have a virtual destructor. Otherwise on
"
SmoothingFilter* filter = ....;
delete filter;
"
The dtor of SmoothingFilter would be called and not the one of the derived
class.

[the sun, 2016/11/09 11:12:17]

Yes, I was wondering whether you could perhaps not mock it and just make this a
simple value class that can be copied around. But that was before I learned that
you were actually using the mock in the test.

   virtual void AddSample(float sample) = 0;
   virtual rtc::Optional<float> GetAverage() const = 0;
 };
 
 // SmoothingFilterImpl applies an exponential filter
 //   alpha = exp(-sample_interval / time_constant);
 //   y[t] = alpha * y[t-1] + (1 - alpha) * sample;
 class SmoothingFilterImpl final : public SmoothingFilter {
  public:
   // |time_constant_ms| is the time constant for the exponential filter.
   SmoothingFilterImpl(int time_constant_ms, const Clock* clock);
 
   void AddSample(float sample) override;
   rtc::Optional<float> GetAverage() const override;
 
  private:
   const int time_constant_ms_;
   const Clock* const clock_;
 
   bool first_sample_received_;
   bool initialized_;
   int64_t first_sample_time_ms_;
   int64_t last_sample_time_ms_;
   rtc::ExpFilter filter_;
 
   RTC_DISALLOW_COPY_AND_ASSIGN(SmoothingFilterImpl);

[the sun, 2016/11/09 10:02:59]

...IMPLICIT_CONSTRUCTORS, since you're not default initing anything here.

[michaelt, 2016/11/09 10:46:34]

Done.

 };
 
 }  // namespace webrtc
 
-#endif  // WEBRTC_MODULES_AUDIO_CODING_AUDIO_NETWORK_ADAPTOR_SMOOTHING_FILTER_H_
+#endif  // WEBRTC_BASE_SMOOTHING_FILTER_H_