webrtc/modules/rtp_rtcp/source/rtp_rtcp_impl.cc - Issue 2484143002: Wire up FlexfecSender in RTPSender and add unit tests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/rtp_rtcp/source/rtp_rtcp_impl.cc

Issue 2484143002: Wire up FlexfecSender in RTPSender and add unit tests. (Closed)

Patch Set: Feedback response 2. Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: webrtc/modules/rtp_rtcp/source/rtp_rtcp_impl.cc

diff --git a/webrtc/modules/rtp_rtcp/source/rtp_rtcp_impl.cc b/webrtc/modules/rtp_rtcp/source/rtp_rtcp_impl.cc

index 664bf3acd1a38d36e77f6610d6fed9903fcb8cae..182f6b6f69f144f268864cedea7e6c63421b0afd 100644

--- a/webrtc/modules/rtp_rtcp/source/rtp_rtcp_impl.cc

+++ b/webrtc/modules/rtp_rtcp/source/rtp_rtcp_impl.cc

@@ -74,6 +74,7 @@ ModuleRtpRtcpImpl::ModuleRtpRtcpImpl(const Configuration& configuration)

configuration.clock,

configuration.outgoing_transport,

configuration.paced_sender,

+ nullptr, // TODO(brandtr): Wire up FlexfecSender here.

configuration.transport_sequence_number_allocator,

configuration.transport_feedback_callback,

configuration.send_bitrate_observer,