Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2483303002: GN: Add //build/toolchain/toolchain.gni to exec_script_whitelist (Closed)

Created:
4 years, 1 month ago by kjellander_webrtc
Modified:
4 years, 1 month ago
Reviewers:
ehmaldonado_webrtc
CC:
webrtc-reviews_webrtc.org, qiang.lu, niklas.enbom, yujie_mao (webrtc), peah-webrtc
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

GN: Add //build/toolchain/toolchain.gni to exec_script_whitelist It's needed for the soon-to-be-rolled chromium_revision. BUG=webrtc:6665 TBR=ehmaldonado@webrtc.org Committed: https://crrev.com/671c0ab4585310c1473c5e92e8640f210c6ad966 Cr-Commit-Position: refs/heads/master@{#14984}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M .gn View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
kjellander_webrtc
4 years, 1 month ago (2016-11-08 18:15:17 UTC) #2
kjellander_webrtc
Committed patchset #1 (id:1) manually as 671c0ab4585310c1473c5e92e8640f210c6ad966 (presubmit successful).
4 years, 1 month ago (2016-11-08 18:15:38 UTC) #4
ehmaldonado_webrtc
4 years, 1 month ago (2016-11-08 18:16:07 UTC) #5
Message was sent while issue was closed. 
On 2016/11/08 18:15:38, kjellander_webrtc wrote:
> Committed patchset #1 (id:1) manually as
> 671c0ab4585310c1473c5e92e8640f210c6ad966 (presubmit successful).

lgtm

Powered by Google App Engine
This is Rietveld 408576698