Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(192)

Issue 2483273002: Revert of Add a webrtc{en,de}coderfactory implementation for VideoToolbox (Closed)

Created:
4 years, 1 month ago by kwiberg-webrtc
Modified:
4 years, 1 month ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, zhengzhonghou_agora.io, video-team_agora.io, stefan-webrtc, mflodman
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Add a webrtc{en,de}coderfactory implementation for VideoToolbox (patchset #2 id:20001 of https://codereview.webrtc.org/2463313002/ ) Reason for revert: Broke dependent project because the .gn changes weren't accompanied by corresponding .gyp changes. Original issue's description: > Add a webrtc{en,de}coderfactory implementation for VideoToolbox > > This CL removes the coupling of the VideoToolbox h264 implementation > to the generic h264 code. The files have been moved into sdb/obj/Framework > and all dependency on them has been removed from the rest of WebRTC. > We now add it as an external encoder via a factory supplied to the > CreatePeerConnectionFactory call. This also brings the iOS implementation > closer to what we do on Android for MediaCodec. > > BUG=webrtc:6619 > > Committed: https://crrev.com/6a5047dad31f14f53dd9f8bc1ecde19e1dede2e4 > Cr-Commit-Position: refs/heads/master@{#14953} TBR=magjed@webrtc.org,stefan@webrtc.org,kthelgason@webrtc.org BUG=webrtc:6619 Committed: https://crrev.com/d69ad84420d9c0e1c11450c352f6c92e7c9583f1 Cr-Commit-Position: refs/heads/master@{#14985}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+195 lines, -2022 lines) Patch
M webrtc/modules/BUILD.gn View 1 chunk +4 lines, -1 line 0 comments Download
M webrtc/modules/video_coding/BUILD.gn View 2 chunks +59 lines, -0 lines 0 comments Download
M webrtc/modules/video_coding/codecs/h264/h264.cc View 4 chunks +28 lines, -0 lines 0 comments Download
M webrtc/modules/video_coding/codecs/h264/h264.gypi View 2 chunks +45 lines, -0 lines 0 comments Download
A + webrtc/modules/video_coding/codecs/h264/h264_objc.mm View 1 chunk +15 lines, -11 lines 0 comments Download
A + webrtc/modules/video_coding/codecs/h264/h264_video_toolbox_decoder.h View 2 chunks +6 lines, -3 lines 0 comments Download
A + webrtc/modules/video_coding/codecs/h264/h264_video_toolbox_decoder.cc View 3 chunks +6 lines, -2 lines 0 comments Download
A + webrtc/modules/video_coding/codecs/h264/h264_video_toolbox_encoder.h View 3 chunks +6 lines, -3 lines 0 comments Download
A + webrtc/modules/video_coding/codecs/h264/h264_video_toolbox_encoder.mm View 3 chunks +6 lines, -2 lines 0 comments Download
A + webrtc/modules/video_coding/codecs/h264/h264_video_toolbox_nalu.h View 2 chunks +6 lines, -3 lines 0 comments Download
A + webrtc/modules/video_coding/codecs/h264/h264_video_toolbox_nalu.cc View 2 chunks +5 lines, -1 line 0 comments Download
A + webrtc/modules/video_coding/codecs/h264/h264_video_toolbox_nalu_unittest.cc View 2 chunks +5 lines, -1 line 0 comments Download
M webrtc/sdk/BUILD.gn View 6 chunks +3 lines, -60 lines 0 comments Download
M webrtc/sdk/DEPS View 1 chunk +0 lines, -2 lines 0 comments Download
M webrtc/sdk/objc/Framework/Classes/RTCPeerConnectionFactory.mm View 2 chunks +1 line, -8 lines 0 comments Download
D webrtc/sdk/objc/Framework/Classes/h264_video_toolbox_decoder.h View 1 chunk +0 lines, -59 lines 0 comments Download
D webrtc/sdk/objc/Framework/Classes/h264_video_toolbox_decoder.cc View 1 chunk +0 lines, -277 lines 0 comments Download
D webrtc/sdk/objc/Framework/Classes/h264_video_toolbox_encoder.h View 1 chunk +0 lines, -95 lines 0 comments Download
D webrtc/sdk/objc/Framework/Classes/h264_video_toolbox_encoder.mm View 1 chunk +0 lines, -660 lines 0 comments Download
D webrtc/sdk/objc/Framework/Classes/h264_video_toolbox_nalu.h View 1 chunk +0 lines, -112 lines 0 comments Download
D webrtc/sdk/objc/Framework/Classes/h264_video_toolbox_nalu.cc View 1 chunk +0 lines, -365 lines 0 comments Download
D webrtc/sdk/objc/Framework/Classes/h264_video_toolbox_nalu_unittest.cc View 1 chunk +0 lines, -204 lines 0 comments Download
D webrtc/sdk/objc/Framework/Classes/videotoolboxvideocodecfactory.h View 1 chunk +0 lines, -50 lines 0 comments Download
D webrtc/sdk/objc/Framework/Classes/videotoolboxvideocodecfactory.cc View 1 chunk +0 lines, -103 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2483273002/1
4 years, 1 month ago (2016-11-08 18:41:09 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-08 18:42:50 UTC) #10
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/d69ad84420d9c0e1c11450c352f6c92e7c9583f1 Cr-Commit-Position: refs/heads/master@{#14985}
4 years, 1 month ago (2016-11-08 19:08:35 UTC) #12
kthelgason
4 years, 1 month ago (2016-11-08 19:40:47 UTC) #13
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.webrtc.org/2487723004/ by kthelgason@webrtc.org.

The reason for reverting is: Fix gyp build.

Powered by Google App Engine
This is Rietveld 408576698