Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issue 2483093003: Use rtc::PacketTransportInterface in WebrtcSession unit test. (Closed)

Created:
4 years, 1 month ago by johan
Modified:
4 years, 1 month ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, sprang_webrtc
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Use rtc::PacketTransportInterface in WebrtcSession unit test. Using rtc::PacketTransportInterface instead of cricket::TransportChannel is a preparation for refactoring channel.cc. BUG=webrtc:6676 Committed: https://crrev.com/669d69bd1512e8613acc9b6d520e575ac78e9ae0 Cr-Commit-Position: refs/heads/master@{#14989}

Patch Set 1 #

Patch Set 2 : Fix unit test. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -12 lines) Patch
M webrtc/api/webrtcsession_unittest.cc View 1 3 chunks +19 lines, -12 lines 0 comments Download

Messages

Total messages: 16 (11 generated)
johan
4 years, 1 month ago (2016-11-08 12:01:54 UTC) #4
Taylor Brandstetter
lgtm
4 years, 1 month ago (2016-11-08 22:00:49 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2483093003/20001
4 years, 1 month ago (2016-11-08 22:12:33 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-11-08 22:14:10 UTC) #14
commit-bot: I haz the power
4 years, 1 month ago (2016-11-08 22:14:23 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/669d69bd1512e8613acc9b6d520e575ac78e9ae0
Cr-Commit-Position: refs/heads/master@{#14989}

Powered by Google App Engine
This is Rietveld 408576698