Remove evil defines out of shared_x_display.h

Remove evil defines out of shared_x_display.h

This is a trivial but dangerous change to remove X11/Xlib.h out of
shared_x_display.h. Since we do not have a strict and automatically
Include-What-You-Use rule, I cannot quite tell whether any Chromium source files
wrongly assume X11/Xlib.h will be included through shared_x_display.h. We can
fix the breaks in Chromium after this change has been failed to integrate to
Chromium.

BUG=webrtc:6513
Committed: https://crrev.com/e083909f85c761574080cad160a8728a2bed7544
Cr-Commit-Position: refs/heads/master@{#14987}

[Hzj_jie, 2016-11-08 02:37:44]

Patchset #1 (id:1) has been deleted

[Hzj_jie, 2016-11-08 03:40:09]

Description was changed from

==========
Remove evil defines out of shared_x_display.h

BUG=webrtc:6513
==========

to

==========
Remove evil defines out of shared_x_display.h

This is a trivial but dangerous change to remove X11/Xlib.h out of
shared_x_display.h. Since we do not have a strict and automatically
Include-What-You-Use rule, I cannot quite tell whether any Chromium source files
wrongly assume X11/Xlib.h will be included through shared_x_display.h. We can
fix the breaks in Chromium after this change has been failed to integrate to
Chromium.

BUG=webrtc:6513
==========

[Hzj_jie, 2016-11-08 03:40:09]

zijiehe@chromium.org changed reviewers:
+ jamiewalch@chromium.org, sergeyu@chromium.org

[Sergey Ulanov, 2016-11-08 18:31:58]

lgtm

https://codereview.webrtc.org/2482963003/diff/20001/webrtc/modules/desktop_ca...
File webrtc/modules/desktop_capture/screen_drawer_linux.cc (right):

https://codereview.webrtc.org/2482963003/diff/20001/webrtc/modules/desktop_ca...
webrtc/modules/desktop_capture/screen_drawer_linux.cc:11: #include <X11/Xlib.h>
Sort includes alphabetically

https://codereview.webrtc.org/2482963003/diff/20001/webrtc/modules/desktop_ca...
File webrtc/modules/desktop_capture/x11/shared_x_display.h (right):

https://codereview.webrtc.org/2482963003/diff/20001/webrtc/modules/desktop_ca...
webrtc/modules/desktop_capture/x11/shared_x_display.h:24: // easily conflict
with other head files.
s/head files/headers/ (or "header files")

[Hzj_jie, 2016-11-08 20:14:23]

I will go ahead to submit this change and see if chromium would be broken.

https://codereview.webrtc.org/2482963003/diff/20001/webrtc/modules/desktop_ca...
File webrtc/modules/desktop_capture/screen_drawer_linux.cc (right):

https://codereview.webrtc.org/2482963003/diff/20001/webrtc/modules/desktop_ca...
webrtc/modules/desktop_capture/screen_drawer_linux.cc:11: #include <X11/Xlib.h>
On 2016/11/08 18:31:58, Sergey Ulanov wrote:
> Sort includes alphabetically

I thought it sorted based on ASCII code.

https://codereview.webrtc.org/2482963003/diff/20001/webrtc/modules/desktop_ca...
File webrtc/modules/desktop_capture/x11/shared_x_display.h (right):

https://codereview.webrtc.org/2482963003/diff/20001/webrtc/modules/desktop_ca...
webrtc/modules/desktop_capture/x11/shared_x_display.h:24: // easily conflict
with other head files.
On 2016/11/08 18:31:58, Sergey Ulanov wrote:
> s/head files/headers/ (or "header files")

Done.

[Hzj_jie, 2016-11-08 20:25:40]

The CQ bit was checked by zijiehe@chromium.org

[Hzj_jie, 2016-11-08 20:25:40]

The patchset sent to the CQ was uploaded after l-g-t-m from sergeyu@chromium.org
Link to the patchset: https://codereview.webrtc.org/2482963003/#ps40001 (title:
"Resolve review comments")

[commit-bot: I haz the power, 2016-11-08 20:25:49]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-11-08 20:47:16]

Description was changed from

==========
Remove evil defines out of shared_x_display.h

This is a trivial but dangerous change to remove X11/Xlib.h out of
shared_x_display.h. Since we do not have a strict and automatically
Include-What-You-Use rule, I cannot quite tell whether any Chromium source files
wrongly assume X11/Xlib.h will be included through shared_x_display.h. We can
fix the breaks in Chromium after this change has been failed to integrate to
Chromium.

BUG=webrtc:6513
==========

to

==========
Remove evil defines out of shared_x_display.h

This is a trivial but dangerous change to remove X11/Xlib.h out of
shared_x_display.h. Since we do not have a strict and automatically
Include-What-You-Use rule, I cannot quite tell whether any Chromium source files
wrongly assume X11/Xlib.h will be included through shared_x_display.h. We can
fix the breaks in Chromium after this change has been failed to integrate to
Chromium.

BUG=webrtc:6513
==========

[commit-bot: I haz the power, 2016-11-08 20:47:16]

Committed patchset #2 (id:40001)

[commit-bot: I haz the power, 2016-11-08 21:00:04]

Description was changed from

==========
Remove evil defines out of shared_x_display.h

This is a trivial but dangerous change to remove X11/Xlib.h out of
shared_x_display.h. Since we do not have a strict and automatically
Include-What-You-Use rule, I cannot quite tell whether any Chromium source files
wrongly assume X11/Xlib.h will be included through shared_x_display.h. We can
fix the breaks in Chromium after this change has been failed to integrate to
Chromium.

BUG=webrtc:6513
==========

to

==========
Remove evil defines out of shared_x_display.h

This is a trivial but dangerous change to remove X11/Xlib.h out of
shared_x_display.h. Since we do not have a strict and automatically
Include-What-You-Use rule, I cannot quite tell whether any Chromium source files
wrongly assume X11/Xlib.h will be included through shared_x_display.h. We can
fix the breaks in Chromium after this change has been failed to integrate to
Chromium.

BUG=webrtc:6513

Committed: https://crrev.com/e083909f85c761574080cad160a8728a2bed7544
Cr-Commit-Position: refs/heads/master@{#14987}
==========

[commit-bot: I haz the power, 2016-11-08 21:00:05]

Patchset 2 (id:??) landed as
https://crrev.com/e083909f85c761574080cad160a8728a2bed7544
Cr-Commit-Position: refs/heads/master@{#14987}