Reland of "Change TWCC send interval to reduce overhead on low BW situations."

Reland of "Change TWCC send interval to reduce overhead on low BW situations."

"Change TWCC send interval to reduce overhead on low BW situations." was first committed in https://codereview.webrtc.org/2381833003/

but was reverted in https://codereview.webrtc.org/2468413009/ due to "float-cast-overflow".

BUG=webrtc:6442, webrtc:6669
Committed: https://crrev.com/8927b0596cd9d32a813f41bbd24a472bf41b341a
Cr-Commit-Position: refs/heads/master@{#14954}

[minyue-webrtc, 2016-11-07 10:21:29]

Description was changed from

==========
Revert "Revert of Change TWCC send interval to reduce overhead on low BW
situations. (patchset #10 id:200001 of https://codereview.webrtc.org/2381833003/
)"

This reverts commit 3326d0ac8232d6e9f6cd696b63f88bd817b0ec62.

BUG=
==========

to

==========
Reland of "Change TWCC send interval to reduce overhead on low BW situations."

"Change TWCC send interval to reduce overhead on low BW situations." was first
committed in https://codereview.webrtc.org/2381833003/

but was reverted in https://codereview.webrtc.org/2468413009/ due to
"float-cast-overflow".

BUG=webrtc:6442
==========

[minyue-webrtc, 2016-11-07 10:21:30]

minyue@webrtc.org changed reviewers:
+ michaelt@webrtc.org, stefan@webrtc.org

[minyue-webrtc, 2016-11-07 10:21:34]

The CQ bit was checked by minyue@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-07 10:21:44]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-11-07 10:25:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-07 10:25:14]

Dry run: Try jobs failed on following builders:
  android_dbg on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/android_dbg/builds/18323)

[minyue-webrtc, 2016-11-07 10:34:07]

Patchset #2 (id:20001) has been deleted

[minyue-webrtc, 2016-11-07 10:34:14]

The CQ bit was checked by minyue@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-07 10:34:26]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-11-07 10:41:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-07 10:41:36]

Dry run: Try jobs failed on following builders:
  linux_rel on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/linux_rel/builds/19900)
  linux_ubsan on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/linux_ubsan/builds/6559)

[minyue-webrtc, 2016-11-07 10:47:43]

Patchset #2 (id:40001) has been deleted

[minyue-webrtc, 2016-11-07 11:10:54]

The CQ bit was checked by minyue@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-07 11:11:05]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-11-07 11:19:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-07 11:19:36]

Dry run: Try jobs failed on following builders:
  mac_rel on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/mac_rel/builds/19865)

[minyue-webrtc, 2016-11-07 11:24:12]

Patchset #2 (id:60001) has been deleted

[minyue-webrtc, 2016-11-07 12:18:57]

Description was changed from

==========
Reland of "Change TWCC send interval to reduce overhead on low BW situations."

"Change TWCC send interval to reduce overhead on low BW situations." was first
committed in https://codereview.webrtc.org/2381833003/

but was reverted in https://codereview.webrtc.org/2468413009/ due to
"float-cast-overflow".

BUG=webrtc:6442
==========

to

==========
Reland of "Change TWCC send interval to reduce overhead on low BW situations."

"Change TWCC send interval to reduce overhead on low BW situations." was first
committed in https://codereview.webrtc.org/2381833003/

but was reverted in https://codereview.webrtc.org/2468413009/ due to
"float-cast-overflow".

BUG=webrtc:6442, webrtc:6669
==========

[minyue-webrtc, 2016-11-07 12:20:51]

Hi Michael and Stefan,

Would you review this? PS1 just kept the old commit, PS2 is a fix.

~~~~~
Stefan, would you check if Bug 6669 is related to this? I put that in BUG,
although I am not sure if it is what 6669 meant.

[minyue-webrtc, 2016-11-07 12:21:05]

The CQ bit was checked by minyue@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-07 12:21:08]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[minyue-webrtc, 2016-11-07 12:34:12]

I also added a unittest.

[stefan-webrtc, 2016-11-07 12:35:46]

lgtm % nits

https://codereview.webrtc.org/2482823002/diff/100001/webrtc/modules/remote_bi...
File webrtc/modules/remote_bitrate_estimator/remote_estimator_proxy.cc (right):

https://codereview.webrtc.org/2482823002/diff/100001/webrtc/modules/remote_bi...
webrtc/modules/remote_bitrate_estimator/remote_estimator_proxy.cc:113:
kTwccReportSize * 8.0 * 1000.0 / kMinSendIntervalMs;
Move these computations outside the critical section.

https://codereview.webrtc.org/2482823002/diff/100001/webrtc/modules/remote_bi...
File webrtc/modules/remote_bitrate_estimator/remote_estimator_proxy_unittest.cc
(right):

https://codereview.webrtc.org/2482823002/diff/100001/webrtc/modules/remote_bi...
webrtc/modules/remote_bitrate_estimator/remote_estimator_proxy_unittest.cc:373:
// bit rate is small. We choose 0 bps as a special case, which also tests
s/bit rate/bitrate

[michaelt, 2016-11-07 12:36:08]

lgtm

[minyue-webrtc, 2016-11-07 12:40:23]

Thanks! Done!

https://codereview.webrtc.org/2482823002/diff/100001/webrtc/modules/remote_bi...
File webrtc/modules/remote_bitrate_estimator/remote_estimator_proxy.cc (right):

https://codereview.webrtc.org/2482823002/diff/100001/webrtc/modules/remote_bi...
webrtc/modules/remote_bitrate_estimator/remote_estimator_proxy.cc:113:
kTwccReportSize * 8.0 * 1000.0 / kMinSendIntervalMs;
On 2016/11/07 12:35:45, stefan-webrtc (holmer) wrote:
> Move these computations outside the critical section.

Done.

https://codereview.webrtc.org/2482823002/diff/100001/webrtc/modules/remote_bi...
File webrtc/modules/remote_bitrate_estimator/remote_estimator_proxy_unittest.cc
(right):

https://codereview.webrtc.org/2482823002/diff/100001/webrtc/modules/remote_bi...
webrtc/modules/remote_bitrate_estimator/remote_estimator_proxy_unittest.cc:373:
// bit rate is small. We choose 0 bps as a special case, which also tests
On 2016/11/07 12:35:45, stefan-webrtc (holmer) wrote:
> s/bit rate/bitrate

Done.

[minyue-webrtc, 2016-11-07 12:40:26]

The CQ bit was checked by minyue@webrtc.org

[minyue-webrtc, 2016-11-07 12:40:27]

The patchset sent to the CQ was uploaded after l-g-t-m from stefan@webrtc.org,
michaelt@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2482823002/#ps120001 (title:
"on comments")

[commit-bot: I haz the power, 2016-11-07 12:40:34]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-11-07 13:49:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-07 13:49:59]

Try jobs failed on following builders:
  win_x64_dbg on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/win_x64_dbg/builds/2869)

[minyue-webrtc, 2016-11-07 14:27:41]

The CQ bit was checked by minyue@webrtc.org

[commit-bot: I haz the power, 2016-11-07 14:27:49]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-11-07 15:51:22]

Description was changed from

==========
Reland of "Change TWCC send interval to reduce overhead on low BW situations."

"Change TWCC send interval to reduce overhead on low BW situations." was first
committed in https://codereview.webrtc.org/2381833003/

but was reverted in https://codereview.webrtc.org/2468413009/ due to
"float-cast-overflow".

BUG=webrtc:6442, webrtc:6669
==========

to

==========
Reland of "Change TWCC send interval to reduce overhead on low BW situations."

"Change TWCC send interval to reduce overhead on low BW situations." was first
committed in https://codereview.webrtc.org/2381833003/

but was reverted in https://codereview.webrtc.org/2468413009/ due to
"float-cast-overflow".

BUG=webrtc:6442, webrtc:6669
==========

[commit-bot: I haz the power, 2016-11-07 15:51:23]

Committed patchset #4 (id:120001)

[commit-bot: I haz the power, 2016-11-07 15:51:32]

Description was changed from

==========
Reland of "Change TWCC send interval to reduce overhead on low BW situations."

"Change TWCC send interval to reduce overhead on low BW situations." was first
committed in https://codereview.webrtc.org/2381833003/

but was reverted in https://codereview.webrtc.org/2468413009/ due to
"float-cast-overflow".

BUG=webrtc:6442, webrtc:6669
==========

to

==========
Reland of "Change TWCC send interval to reduce overhead on low BW situations."

"Change TWCC send interval to reduce overhead on low BW situations." was first
committed in https://codereview.webrtc.org/2381833003/

but was reverted in https://codereview.webrtc.org/2468413009/ due to
"float-cast-overflow".

BUG=webrtc:6442, webrtc:6669

Committed: https://crrev.com/8927b0596cd9d32a813f41bbd24a472bf41b341a
Cr-Commit-Position: refs/heads/master@{#14954}
==========

[commit-bot: I haz the power, 2016-11-07 15:51:34]

Patchset 4 (id:??) landed as
https://crrev.com/8927b0596cd9d32a813f41bbd24a472bf41b341a
Cr-Commit-Position: refs/heads/master@{#14954}