Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Issue 2482403002: Reland of Add bitrate section to settings view controller. (Closed)

Created:
4 years, 1 month ago by daniela-webrtc
Modified:
4 years, 1 month ago
Reviewers:
magjed_webrtc, kthelgasson
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Reland of Add bitrate section to settings view controller. (patchset #1 id:1 of https://codereview.webrtc.org/2488653002/ ) Reason for revert: Reland Original issue's description: > Revert of Add bitrate section to settings view controller. (patchset #1 id:1 of https://codereview.webrtc.org/2473783003/ ) > > Reason for revert: > The usage of UIKeyboardTypeASCIICapableNumberPad enum (available only for iOS 10.0), is breaking the build of AppRTCMobile on devices with lesser os. > To re-land the UIKeyboardTypeASCIICapableNumberPad should be replaced with UIKeyboardTypeNumberPad > > Original issue's description: > > Add bitrate section to settings view controller. > > > > BUG=webrtc:6654 > > > > Committed: https://crrev.com/3babb99039478c36be58171c5409eac07ae153e5 > > Cr-Commit-Position: refs/heads/master@{#14952} > > TBR=magjed@webrtc.org,kthelgasson@webrtc.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=webrtc:6654 > > Committed: https://crrev.com/40532a164663f03b812ec7ccc893da7a4bdc26d3 > Cr-Commit-Position: refs/heads/master@{#14972} TBR=magjed@webrtc.org,kthelgasson@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:6654 Committed: https://crrev.com/b04b5c205af653c04a621278db9c6d80433722ba Cr-Commit-Position: refs/heads/master@{#14996}

Patch Set 1 #

Patch Set 2 : Fix method #

Unified diffs Side-by-side diffs Delta from patch set Stats (+74 lines, -5 lines) Patch
M webrtc/examples/objc/AppRTCMobile/ios/ARDMainViewController.m View 1 1 chunk +1 line, -1 line 0 comments Download
M webrtc/examples/objc/AppRTCMobile/ios/ARDSettingsViewController.m View 1 4 chunks +73 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
daniela-webrtc
Created Reland of Add bitrate section to settings view controller.
4 years, 1 month ago (2016-11-09 09:38:20 UTC) #1
daniela-webrtc
4 years, 1 month ago (2016-11-09 10:33:29 UTC) #2
magjed_webrtc
lgtm :)
4 years, 1 month ago (2016-11-09 10:36:27 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2482403002/70001
4 years, 1 month ago (2016-11-09 12:28:42 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:70001)
4 years, 1 month ago (2016-11-09 12:28:49 UTC) #6
commit-bot: I haz the power
4 years, 1 month ago (2016-11-09 12:28:59 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/b04b5c205af653c04a621278db9c6d80433722ba
Cr-Commit-Position: refs/heads/master@{#14996}

Powered by Google App Engine
This is Rietveld 408576698