Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issue 2481363008: Make sure that multiband processing is active when the residual echo detector is active. (Closed)

Created:
4 years, 1 month ago by ivoc
Modified:
4 years, 1 month ago
Reviewers:
peah-webrtc, peah
CC:
webrtc-reviews_webrtc.org, Andrew MacDonald, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, kwiberg-webrtc, minyue-webrtc, the sun, aluebs-webrtc, bjornv1
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Make sure that multiband processing is active when the residual echo detector is active. BUG=webrtc:6525 Committed: https://crrev.com/20270be8079e4d974cf7f8dc0b77cc4ca7542e6b Cr-Commit-Position: refs/heads/master@{#15081}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -3 lines) Patch
M webrtc/modules/audio_processing/audio_processing_impl.cc View 2 chunks +6 lines, -3 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
ivoc
Hi Per, Please have a look at this small CL.
4 years, 1 month ago (2016-11-10 15:41:14 UTC) #3
peah-webrtc
On 2016/11/10 15:41:14, ivoc wrote: > Hi Per, Please have a look at this small ...
4 years, 1 month ago (2016-11-15 10:50:41 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2481363008/1
4 years, 1 month ago (2016-11-15 11:19:40 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_tsan2 on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/linux_tsan2/builds/16975)
4 years, 1 month ago (2016-11-15 11:32:59 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2481363008/1
4 years, 1 month ago (2016-11-15 11:38:00 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-15 13:24:39 UTC) #12
commit-bot: I haz the power
4 years, 1 month ago (2016-11-15 13:24:50 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/20270be8079e4d974cf7f8dc0b77cc4ca7542e6b
Cr-Commit-Position: refs/heads/master@{#15081}

Powered by Google App Engine
This is Rietveld 408576698