Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(417)

Issue 2481343004: Fix forward declaration typo in UlpfecGenerator. (Closed)

Created:
4 years, 1 month ago by brandtr
Modified:
4 years, 1 month ago
Reviewers:
stefan-webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, zhuangzesen_agora.io, danilchap, stefan-webrtc, mflodman
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Fix forward declaration typo in UlpfecGenerator. BUG=webrtc:5654 NOTRY=true Committed: https://crrev.com/9ed35a4bd3ab40092e79763deee57b5a669eb549 Cr-Commit-Position: refs/heads/master@{#14963}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M webrtc/modules/rtp_rtcp/source/ulpfec_generator.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
brandtr
This error never surfaced. Maybe flexfec_sender.h was always included before ulpfec_generator.h, wherever the latter was ...
4 years, 1 month ago (2016-11-08 08:13:23 UTC) #2
stefan-webrtc
lgtm
4 years, 1 month ago (2016-11-08 08:24:00 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2481343004/1
4 years, 1 month ago (2016-11-08 08:25:23 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-08 08:29:03 UTC) #6
commit-bot: I haz the power
4 years, 1 month ago (2016-11-08 08:29:12 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9ed35a4bd3ab40092e79763deee57b5a669eb549
Cr-Commit-Position: refs/heads/master@{#14963}

Powered by Google App Engine
This is Rietveld 408576698