Provide move semantic for cricket::Codec and subclasses

Provide move semantic for cricket::Codec and subclasses

The cricket::Codec class contains std containers like
std::map<std::string, std::string> and is expensive to copy. This CL
adds move constructors and move assignment operators for it and all
subclasses.

This CL also:
 * Implement functions with '= default' instead of doing it manually.
 * Makes codec::Matches symmetric. We currently don't check if the
   payload type of the callee is static, and might incorrectly return
   true in these cases.

BUG=None

Committed: https://crrev.com/3663c523820c520806e5a9a0269063cc1adf3657
Cr-Commit-Position: refs/heads/master@{#14956}

[magjed_webrtc, 2016-11-07 13:09:21]

Description was changed from

==========
Provide move semantic for cricket::Codec and subclasses

The cricket::Codec class contains std containers like
std::map<std::string, std::string> and is expensive to copy. This CL
adds move constructors and move assignment operators for it and all
subclasses.

This CL also:
 * Implement functions with '= default' instead of doing it manually.
 * Make codec::Matches symmetric. We currently don't check if the
   payload type of the callee is static, and might incorrectly return
   true in these cases.

BUG=None
==========

to

==========
Provide move semantic for cricket::Codec and subclasses

The cricket::Codec class contains std containers like
std::map<std::string, std::string> and is expensive to copy. This CL
adds move constructors and move assignment operators for it and all
subclasses.

This CL also:
 * Implement functions with '= default' instead of doing it manually.
 * Makes codec::Matches symmetric. We currently don't check if the
   payload type of the callee is static, and might incorrectly return
   true in these cases.

BUG=None
==========

[magjed_webrtc, 2016-11-07 13:10:46]

magjed@webrtc.org changed reviewers:
+ kthelgason@webrtc.org

[kthelgason, 2016-11-07 13:37:18]

solid improvement, lgtm.

[magjed_webrtc, 2016-11-07 14:08:54]

The CQ bit was checked by magjed@webrtc.org

[magjed_webrtc, 2016-11-07 14:08:54]

The patchset sent to the CQ was uploaded after l-g-t-m from
kthelgason@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2481193002/#ps20001 (title:
"Remove some faulty test.")

[commit-bot: I haz the power, 2016-11-07 14:08:58]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-11-07 18:14:38]

Description was changed from

==========
Provide move semantic for cricket::Codec and subclasses

The cricket::Codec class contains std containers like
std::map<std::string, std::string> and is expensive to copy. This CL
adds move constructors and move assignment operators for it and all
subclasses.

This CL also:
 * Implement functions with '= default' instead of doing it manually.
 * Makes codec::Matches symmetric. We currently don't check if the
   payload type of the callee is static, and might incorrectly return
   true in these cases.

BUG=None
==========

to

==========
Provide move semantic for cricket::Codec and subclasses

The cricket::Codec class contains std containers like
std::map<std::string, std::string> and is expensive to copy. This CL
adds move constructors and move assignment operators for it and all
subclasses.

This CL also:
 * Implement functions with '= default' instead of doing it manually.
 * Makes codec::Matches symmetric. We currently don't check if the
   payload type of the callee is static, and might incorrectly return
   true in these cases.

BUG=None
==========

[commit-bot: I haz the power, 2016-11-07 18:14:39]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-11-07 18:14:51]

Description was changed from

==========
Provide move semantic for cricket::Codec and subclasses

The cricket::Codec class contains std containers like
std::map<std::string, std::string> and is expensive to copy. This CL
adds move constructors and move assignment operators for it and all
subclasses.

This CL also:
 * Implement functions with '= default' instead of doing it manually.
 * Makes codec::Matches symmetric. We currently don't check if the
   payload type of the callee is static, and might incorrectly return
   true in these cases.

BUG=None
==========

to

==========
Provide move semantic for cricket::Codec and subclasses

The cricket::Codec class contains std containers like
std::map<std::string, std::string> and is expensive to copy. This CL
adds move constructors and move assignment operators for it and all
subclasses.

This CL also:
 * Implement functions with '= default' instead of doing it manually.
 * Makes codec::Matches symmetric. We currently don't check if the
   payload type of the callee is static, and might incorrectly return
   true in these cases.

BUG=None

Committed: https://crrev.com/3663c523820c520806e5a9a0269063cc1adf3657
Cr-Commit-Position: refs/heads/master@{#14956}
==========

[commit-bot: I haz the power, 2016-11-07 18:14:52]

Patchset 2 (id:??) landed as
https://crrev.com/3663c523820c520806e5a9a0269063cc1adf3657
Cr-Commit-Position: refs/heads/master@{#14956}