Generate ADMX template for Chrome OS policies

Generate ADMX template for Chrome OS policies

Generates an ADMX template to be used for editing policy on a
Windows AD server. The resulting GPOs can be fetched with the
authpolicy code written for the Chromad project (see Chromium
OS code base).

A single ADMX template is generated that contains both user and
device policy, using ADMX's CLASS attribute to distinguish the
two.

BUG=638560
TEST=Compiles and generates templates

Review-Url: https://chromiumcodereview.appspot.com/2481183002
Cr-Commit-Position: refs/heads/master@{#503142}
Committed: https://chromium.googlesource.com/chromium/src/+/7a912ab95678117a84e94a33fb9e69da77d98f28

[ljusten (tachyonic), 2016-11-07 13:20:17]

ljusten@chromium.org changed reviewers:
+ pastarmovj@chromium.org

[ljusten (tachyonic), 2016-11-07 13:20:18]

As discussed, PTAL. If you're surprised about the '_Item' suffix addition, there
was a name collision for the 'SyncDisabled' policy and the 'SyncDisabled' item
in the 'ArcCertificatesSyncMode' policy. The collision didn't show up on Windows
since the latter policy is Chrome OS-only.

[ljusten (tachyonic), 2016-11-08 09:39:43]

The CQ bit was checked by ljusten@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-08 09:40:14]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-08 11:04:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-08 11:04:58]

Dry run: Try jobs failed on following builders:
  win_clang on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_clang/builds/...)

[pastarmovj, 2016-11-08 12:16:37]

test if branded builds are ok otherwise lgtm.

[ljusten (tachyonic), 2016-12-19 17:48:46]

Patchset #5 (id:80001) has been deleted

[ljusten (tachyonic), 2017-01-04 16:25:20]

On 2016/11/08 12:16:37, pastarmovj wrote:
> test if branded builds are ok otherwise lgtm.

Everything looks good as far as I can tell. Can I proceed with it? I'd like to
get it into M57.

[pastarmovj, 2017-01-04 17:04:36]

no new objections on my end - you are good to go as long as you get all owner
approvals you need.

[ljusten (tachyonic), 2017-01-04 17:04:46]

ljusten@chromium.org changed reviewers:
+ thakis@chromium.org

[ljusten (tachyonic), 2017-01-04 17:04:47]

thakis@chromium.org: pastarmovj@ has already checked this CL, but he's not an
owner of grit anymore. Could you please take a look? I talked to him a while
back and IIRC he said he used to be an owner and wouldn't mind being added back.
Maybe that's an option, too, if everybody is fine with that.

I'd like to get this into M-57 to unblock another project (Chromad).

[pastarmovj, 2017-01-04 18:44:43]

On 2017/01/04 17:04:47, ljusten wrote:
> mailto:thakis@chromium.org: pastarmovj@ has already checked this CL, but he's
not an
> owner of grit anymore. Could you please take a look? I talked to him a while
> back and IIRC he said he used to be an owner and wouldn't mind being added
back.
> Maybe that's an option, too, if everybody is fine with that.
> 
> I'd like to get this into M-57 to unblock another project (Chromad).

To clarify I was only an owner of the policy_templates dir together with
mnissler and joaodasilva iirc.

[ljusten (tachyonic), 2017-01-09 09:33:05]

On 2017/01/04 17:04:47, ljusten wrote:
> mailto:thakis@chromium.org: pastarmovj@ has already checked this CL, but he's
not an
> owner of grit anymore. Could you please take a look? I talked to him a while
> back and IIRC he said he used to be an owner and wouldn't mind being added
back.
> Maybe that's an option, too, if everybody is fine with that.
> 
> I'd like to get this into M-57 to unblock another project (Chromad).

Actually, it's enough to have this in M-58 as we grab ADMX templates from the
dev branch, not the stable branch.

[Nico, 2017-01-09 15:18:07]

thakis@chromium.org changed reviewers:
+ mnissler@chromium.org

[Nico, 2017-01-09 15:18:07]

+mnissler who had opinions on ADMX templates a while ago

[ljusten (tachyonic), 2017-01-17 15:24:11]

On 2017/01/09 15:18:07, Nico wrote:
> +mnissler who had opinions on ADMX templates a while ago

I'm afraid Mathias is on parental leave until April.

[ljusten (tachyonic), 2017-07-28 17:53:27]

Friendly ping. We'd like to get this in sometime around mid August since the
ADMX templates are going to be required for the Chromad launch.

[Nico, 2017-07-28 19:04:38]

Prefix pings with username of person you're pinging to save people a click.

mnissler: ping

[ljusten (tachyonic), 2017-07-31 10:16:03]

Right, thanks. I hope there's going to be enough time between Mattias' vacation
(until Aug 11) and mine (from Aug 21).

[Mattias Nissler (ping if slow), 2017-08-14 09:18:07]

Since you're asking here's my opinion (but note that I'm neither a grit nor a
policy OWNER, so decision making is on you):

The policy template generation code in grit was originally very simply,
essentially just "dumping strings in a different text file format". That was the
original justification why this code could live in grit. However, the template
generation code has grown more complex to support more template formats, use
cases, platforms, etc. Given that, I think it's time to refactor this so grit is
responsible for translations (and only that, since that's what it's meant for)
and break out the policy template generation into a separate tool that turns
policy_template.json + grit output into various template files. There's even an
old bug file for this:
https://bugs.chromium.org/p/chromium/issues/detail?id=165412

Since this CL adds yet another dimension of complexity, it might be the right
point in time for the grit OWNERS to make up their mind on this.

Other than that, I don't have anything to add. The CL looks sane at a conceptual
level, but I haven't done a detailed review.

[ljusten (tachyonic), 2017-08-16 12:40:39]

Nico: ping

[Nico, 2017-08-16 13:15:12]

On 2017/08/16 12:40:39, ljusten (tachyonic) wrote:
> Nico: ping

mnissler's recommendation makes sense to me.

[ljusten (tachyonic), 2017-08-16 14:10:52]

> mnissler's recommendation makes sense to me.

I'm happy to take this refactoring, but I don't think it makes sense to weave it
into this CL. We need the ADMX templates since we're launching the product very
soon and I have two (much smaller) CLs that also depend on this change. I'll try
to make time after my vacation to move the stuff over to Chrome land. Sounds
fair?

[ljusten (tachyonic), 2017-09-20 13:41:27]

Description was changed from

==========
Generate ADMX template for Chrome OS policies

Generates an ADMX template to be used for editing policy on a
Windows AD server. The resulting GPOs can be fetched with the
authpolicy code written for the Chromad project (see Chromium
OS code base).

A single ADMX template is generated that contains both user and
device policy, using ADMX's CLASS attribute to distinguish the
two.

BUG=638560
TEST=Compiles and generates templates
==========

to

==========
Generate ADMX template for Chrome OS policies

Generates an ADMX template to be used for editing policy on a
Windows AD server. The resulting GPOs can be fetched with the
authpolicy code written for the Chromad project (see Chromium
OS code base).

A single ADMX template is generated that contains both user and
device policy, using ADMX's CLASS attribute to distinguish the
two.

BUG=638560
TEST=Compiles and generates templates
==========

[ljusten (tachyonic), 2017-09-20 13:41:27]

ljusten@chromium.org changed reviewers:
- mnissler@chromium.org, thakis@chromium.org

[ljusten (tachyonic), 2017-09-20 13:42:52]

On 2017/08/16 14:10:52, ljusten (tachyonic) wrote:
> > mnissler's recommendation makes sense to me.
> 
> I'm happy to take this refactoring, but I don't think it makes sense to weave
it
> into this CL. We need the ADMX templates since we're launching the product
very
> soon and I have two (much smaller) CLs that also depend on this change. I'll
try
> to make time after my vacation to move the stuff over to Chrome land. Sounds
> fair?

The template writers have been moved out of grit by CL:654870. The latest patch
set
is already rebased to this new version where all changes live in
components/policy.

[ljusten (tachyonic), 2017-09-20 13:53:53]

The CQ bit was checked by ljusten@chromium.org

[ljusten (tachyonic), 2017-09-20 13:53:54]

The patchset sent to the CQ was uploaded after l-g-t-m from
pastarmovj@chromium.org
Link to the patchset: https://codereview.chromium.org/2481183002/#ps280001
(title: "Couple of fixes after testing")

[commit-bot: I haz the power, 2017-09-20 13:53:58]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-09-20 15:01:55]

CQ is committing da patch.

Bot data: {"patchset_id": 280001, "attempt_start_ts": 1505915633515680,
"parent_rev": "5ec011680b8389e26f1ce9a57e960a9f5a775cce", "commit_rev":
"7a912ab95678117a84e94a33fb9e69da77d98f28"}

[commit-bot: I haz the power, 2017-09-20 15:02:15]

Description was changed from

==========
Generate ADMX template for Chrome OS policies

Generates an ADMX template to be used for editing policy on a
Windows AD server. The resulting GPOs can be fetched with the
authpolicy code written for the Chromad project (see Chromium
OS code base).

A single ADMX template is generated that contains both user and
device policy, using ADMX's CLASS attribute to distinguish the
two.

BUG=638560
TEST=Compiles and generates templates
==========

to

==========
Generate ADMX template for Chrome OS policies

Generates an ADMX template to be used for editing policy on a
Windows AD server. The resulting GPOs can be fetched with the
authpolicy code written for the Chromad project (see Chromium
OS code base).

A single ADMX template is generated that contains both user and
device policy, using ADMX's CLASS attribute to distinguish the
two.

BUG=638560
TEST=Compiles and generates templates

Review-Url: https://chromiumcodereview.appspot.com/2481183002
Cr-Commit-Position: refs/heads/master@{#503142}
Committed:
https://chromium.googlesource.com/chromium/src/+/7a912ab95678117a84e94a33fb9e...
==========

[commit-bot: I haz the power, 2017-09-20 15:02:17]

Committed patchset #14 (id:280001) as
https://chromium.googlesource.com/chromium/src/+/7a912ab95678117a84e94a33fb9e...