Fix video_loopback on Mac.

Fix video_loopback program to work on Mac.
The VideoStreams created by the VideoStreamFactory must match the incoming video resolution from the camera. On mac, the camera is opened at hd but the configured streams contain only a VGA stream. This cl change the VideoStreamFactory to always set the highest layer to match the resolution of the incoming frame.

BUG=none
R=stefan@webrtc.org

[perkj_webrtc, 2016-11-04 13:42:27]

please

[perkj_webrtc, 2016-11-04 13:42:51]

Description was changed from

==========
Fix video_loopback to work on Mac.
The VideoStreams created by the VideoStreamFactory must match the incoming video
resolution from the camera. On mac, the camera is opened at hd but the
configured streams contain only a VGA stream. This cl change the
VideoStreamFactory to always set the highest layer to match the resolution of
the incoming frame.

BUG=none
R=stefan@webrtc.org
==========

to

==========
Fix video_loop_back program to work on Mac.
The VideoStreams created by the VideoStreamFactory must match the incoming video
resolution from the camera. On mac, the camera is opened at hd but the
configured streams contain only a VGA stream. This cl change the
VideoStreamFactory to always set the highest layer to match the resolution of
the incoming frame.

BUG=none
R=stefan@webrtc.org
==========

[stefan-webrtc, 2016-11-09 18:19:29]

Shouldn't we scale the frame down to appropriate resolution?

https://codereview.webrtc.org/2480753002/diff/1/webrtc/video/video_quality_te...
File webrtc/video/video_quality_test.cc (right):

https://codereview.webrtc.org/2480753002/diff/1/webrtc/video/video_quality_te...
webrtc/video/video_quality_test.cc:105: streams[streams_.size() -1].width =
width;
"streams_.size() - 1"

[stefan-webrtc, 2016-11-09 18:19:41]

Description was changed from

==========
Fix video_loop_back program to work on Mac.
The VideoStreams created by the VideoStreamFactory must match the incoming video
resolution from the camera. On mac, the camera is opened at hd but the
configured streams contain only a VGA stream. This cl change the
VideoStreamFactory to always set the highest layer to match the resolution of
the incoming frame.

BUG=none
R=stefan@webrtc.org
==========

to

==========
Fix video_loopback program to work on Mac.
The VideoStreams created by the VideoStreamFactory must match the incoming video
resolution from the camera. On mac, the camera is opened at hd but the
configured streams contain only a VGA stream. This cl change the
VideoStreamFactory to always set the highest layer to match the resolution of
the incoming frame.

BUG=none
R=stefan@webrtc.org
==========

[perkj_webrtc, 2016-11-10 12:03:54]

ViEEncoder will send whatever resolution that is provided to it. 
That is the same way it has been used in production for years. 
However, VieEncoder had a build in scaler (VideoProcessor) was only used by
tests prior to this cl: https://codereview.webrtc.org/2351633002/

https://codereview.webrtc.org/2480753002/diff/1/webrtc/video/video_quality_te...
File webrtc/video/video_quality_test.cc (right):

https://codereview.webrtc.org/2480753002/diff/1/webrtc/video/video_quality_te...
webrtc/video/video_quality_test.cc:105: streams[streams_.size() -1].width =
width;
On 2016/11/09 18:19:29, stefan-webrtc (holmer) wrote:
> "streams_.size() - 1"

Done.

[stefan-webrtc, 2016-11-15 09:14:28]

On 2016/11/10 12:03:54, perkj_webrtc wrote:
> ViEEncoder will send whatever resolution that is provided to it. 
> That is the same way it has been used in production for years. 
> However, VieEncoder had a build in scaler (VideoProcessor) was only used by
> tests prior to this cl: https://codereview.webrtc.org/2351633002/
> 
>
https://codereview.webrtc.org/2480753002/diff/1/webrtc/video/video_quality_te...
> File webrtc/video/video_quality_test.cc (right):
> 
>
https://codereview.webrtc.org/2480753002/diff/1/webrtc/video/video_quality_te...
> webrtc/video/video_quality_test.cc:105: streams[streams_.size() -1].width =
> width;
> On 2016/11/09 18:19:29, stefan-webrtc (holmer) wrote:
> > "streams_.size() - 1"
> 
> Done.

Ok, so the question is, is it now possible to start a video_loopback call on Mac
where the resolution sent is lower than HD? If not it seems to me that we should
add scaling to video_loopback in this CL?

[mflodman, 2016-12-15 14:33:35]

mflodman@webrtc.org changed reviewers:
+ mflodman@webrtc.org

[mflodman, 2016-12-15 14:33:35]

https://codereview.webrtc.org/2480753002/diff/20001/webrtc/video/video_qualit...
File webrtc/video/video_quality_test.cc (right):

https://codereview.webrtc.org/2480753002/diff/20001/webrtc/video/video_qualit...
webrtc/video/video_quality_test.cc:106: return streams_;
You need to return 'streams', not 'streams_'.

[mflodman, 2016-12-16 07:58:17]

I patched and committed this in
https://crrev.com/d79f97b542a303ca8b7f9a95d5bda5c605d5c59d
so I closed this one.

I hope this was ok Per.