Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: webrtc/modules/video_coding/packet_buffer.h

Issue 2480293002: New jitter buffer experiment. (Closed)
Patch Set: jitter_buffer_experiment_ made const. Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webrtc/modules/video_coding/frame_buffer2_unittest.cc ('k') | webrtc/modules/video_coding/packet_buffer.cc » ('j') | webrtc/modules/video_coding/rtp_frame_reference_finder.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/modules/video_coding/packet_buffer.h
diff --git a/webrtc/modules/video_coding/packet_buffer.h b/webrtc/modules/video_coding/packet_buffer.h
index 15645f607a86cd9df2c4df946ae6e32f63ad497c..9270398e0b29d1efd5aa1c67e8dfc4f42b428bb5 100644
--- a/webrtc/modules/video_coding/packet_buffer.h
+++ b/webrtc/modules/video_coding/packet_buffer.h
@@ -99,8 +99,9 @@ class PacketBuffer {
EXCLUSIVE_LOCKS_REQUIRED(crit_);
// Test if all packets of a frame has arrived, and if so, creates a frame.
- // May create multiple frames per invocation.
- void FindFrames(uint16_t seq_num) EXCLUSIVE_LOCKS_REQUIRED(crit_);
+ // Return a vector received frames.
stefan-webrtc 2016/11/14 12:00:26 Returns a vector of received frames
philipel 2016/11/14 15:31:03 Done.
+ std::vector<std::unique_ptr<RtpFrameObject>> FindFrames(uint16_t seq_num)
+ EXCLUSIVE_LOCKS_REQUIRED(crit_);
// Copy the bitstream for |frame| to |destination|.
// Virtual for testing.
@@ -108,7 +109,8 @@ class PacketBuffer {
// Get the packet with sequence number |seq_num|.
// Virtual for testing.
- virtual VCMPacket* GetPacket(uint16_t seq_num);
+ virtual VCMPacket* GetPacket(uint16_t seq_num)
+ EXCLUSIVE_LOCKS_REQUIRED(crit_);
// Mark all slots used by |frame| as not used.
// Virtual for testing.
« no previous file with comments | « webrtc/modules/video_coding/frame_buffer2_unittest.cc ('k') | webrtc/modules/video_coding/packet_buffer.cc » ('j') | webrtc/modules/video_coding/rtp_frame_reference_finder.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698