New jitter buffer experiment.

webrtc/modules/video_coding/codecs/vp9/vp9_impl.cc

 /*
  *  Copyright (c) 2014 The WebRTC project authors. All Rights Reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  *
  */
@@ skipping 238 matching lines @@
   if (inst->VP9().numberOfSpatialLayers > 2) {
     return WEBRTC_VIDEO_CODEC_ERR_PARAMETER;
   }
 
   int ret_val = Release();
   if (ret_val < 0) {
     return ret_val;
   }
   if (encoder_ == NULL) {
     encoder_ = new vpx_codec_ctx_t;
+    // Random start 16 bits is enough.
+    picture_id_ = static_cast<uint16_t>(rand()) & 0x7FFF;  // NOLINT
+    tl0_pic_idx_ = static_cast<uint8_t>(rand());           // NOLINT

[stefan-webrtc, 2016/11/08 10:41:34]

Not clear to me why this change is done, and why it's in this CL. Please
comment.

[philipel, 2016/11/08 12:28:39]

Done.

[stefan-webrtc, 2016/11/08 14:49:27]

The problem is that if we're relying on this change for the new JB to work,
we'll not be compatible with old Chrome versions. So either we'll have to filter
out VP9 from the experiment for a couple of versions, or we find a way to handle
it on the receiver...

[philipel, 2016/11/10 16:13:53]

Fixed in RtpFrameReferenceFinder

   }
   if (config_ == NULL) {
     config_ = new vpx_codec_enc_cfg_t;
   }
   timestamp_ = 0;
   if (&codec_ != inst) {
     codec_ = *inst;
   }
 
   num_spatial_layers_ = inst->VP9().numberOfSpatialLayers;
   num_temporal_layers_ = inst->VP9().numberOfTemporalLayers;
   if (num_temporal_layers_ == 0)
     num_temporal_layers_ = 1;
 
-  // Random start 16 bits is enough.
-  picture_id_ = static_cast<uint16_t>(rand()) & 0x7FFF;  // NOLINT
   // Allocate memory for encoded image
   if (encoded_image_._buffer != NULL) {
     delete[] encoded_image_._buffer;
   }
   encoded_image_._size = CalcBufferSize(kI420, codec_.width, codec_.height);
   encoded_image_._buffer = new uint8_t[encoded_image_._size];
   encoded_image_._completeFrame = true;
   // Creating a wrapper to the image - setting image data to NULL. Actual
   // pointer will be set in encode. Setting align to 1, as it is meaningless
   // (actual memory is not allocated).
@@ skipping 74 matching lines @@
     config_->ts_rate_decimator[2] = 1;
     config_->ts_periodicity = 4;
     config_->ts_layer_id[0] = 0;
     config_->ts_layer_id[1] = 2;
     config_->ts_layer_id[2] = 1;
     config_->ts_layer_id[3] = 2;
   } else {
     return WEBRTC_VIDEO_CODEC_ERR_PARAMETER;
   }
 
-  tl0_pic_idx_ = static_cast<uint8_t>(rand());  // NOLINT
-
   return InitAndSetControlSettings(inst);
 }
 
 int VP9EncoderImpl::NumberOfThreads(int width,
                                     int height,
                                     int number_of_cores) {
   // Keep the number of encoder threads equal to the possible number of column
   // tiles, which is (1, 2, 4, 8). See comments below for VP9E_SET_TILE_COLUMNS.
   if (width * height >= 1280 * 720 && number_of_cores > 4) {
     return 4;
@@ skipping 613 matching lines @@
   frame_buffer_pool_.ClearPool();
   inited_ = false;
   return WEBRTC_VIDEO_CODEC_OK;
 }
 
 const char* VP9DecoderImpl::ImplementationName() const {
   return "libvpx";
 }
 
 }  // namespace webrtc