webrtc/modules/desktop_capture/mac/full_screen_chrome_window_detector.cc - Issue 2479553006: Remove GetWindowList / GetScreenList and SelectWindow / SelectScreen from WebRTC

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/desktop_capture/mac/full_screen_chrome_window_detector.cc

Issue 2479553006: Remove GetWindowList / GetScreenList and SelectWindow / SelectScreen from WebRTC (Closed)

Patch Set: Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « webrtc/modules/desktop_capture/mac/full_screen_chrome_window_detector.h ('k') | webrtc/modules/desktop_capture/mac/window_list_utils.h » ('j') | webrtc/modules/desktop_capture/mac/window_list_utils.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: webrtc/modules/desktop_capture/mac/full_screen_chrome_window_detector.cc

diff --git a/webrtc/modules/desktop_capture/mac/full_screen_chrome_window_detector.cc b/webrtc/modules/desktop_capture/mac/full_screen_chrome_window_detector.cc

index 451acb3db5ed80621b19652f97b272416fb73eaa..c81e48ae3d8f8ebc48462ccd98906cde90f60586 100644

--- a/webrtc/modules/desktop_capture/mac/full_screen_chrome_window_detector.cc

+++ b/webrtc/modules/desktop_capture/mac/full_screen_chrome_window_detector.cc

@@ -157,7 +157,7 @@ CGWindowID FullScreenChromeWindowDetector::FindFullScreenWindow(

if (full_screen_window_id == kCGNullWindowID)

return kCGNullWindowID;

- for (WindowCapturer::WindowList::iterator it = previous_window_list_.begin();

+ for (auto it = previous_window_list_.begin();

Sergey Ulanov 2016/11/07 20:20:56 replace this with a range loop?

Hzj_jie 2016/11/07 23:00:18 Done.

it != previous_window_list_.end(); ++it) {

if (static_cast<CGWindowID>(it->id) != full_screen_window_id)

continue;