Remove GetWindowList / GetScreenList and SelectWindow / SelectScreen from WebRTC

Implement and use new DesktopCapturer APIs in WebRTC

This change replaces all GetWindowList / GetScreenList with GetScreenList,
SelectWindow / SelectScreen with SelectSource, and BringSelectedWindowToFront
with FocusOnSelectedSource in WebRTC.

BUG=webrtc:6513
Committed: https://crrev.com/fce4905987d650a3119b1071d42166c8d430d4d3
Cr-Commit-Position: refs/heads/master@{#14960}

[Hzj_jie, 2016-11-04 22:07:13]

Patchset #1 (id:1) has been deleted

[Hzj_jie, 2016-11-04 22:43:18]

Patchset #1 (id:20001) has been deleted

[Hzj_jie, 2016-11-04 22:49:15]

Patchset #1 (id:40001) has been deleted

[Hzj_jie, 2016-11-04 22:56:33]

Description was changed from

==========
Remove GetWindowList / GetScreenList and SelectWindow / SelectScreen from WebRTC

BUG=webrtc:6513
==========

to

==========
Implement and use new DesktopCapturer APIs in WebRTC

This change replaces all GetWindowList / GetScreenList with GetScreenList,
SelectWindow / SelectScreen with SelectSource, and BringSelectedWindowToFront
with FocusOnSelectedSource in WebRTC.

BUG=webrtc:6513
==========

[Hzj_jie, 2016-11-06 04:57:45]

zijiehe@chromium.org changed reviewers:
+ jamiewalch@chromium.org, sergeyu@chromium.org

[Sergey Ulanov, 2016-11-07 20:20:57]

lgtm when my comments addressed

https://codereview.webrtc.org/2479553006/diff/60001/webrtc/modules/desktop_ca...
File webrtc/modules/desktop_capture/mac/full_screen_chrome_window_detector.cc
(right):

https://codereview.webrtc.org/2479553006/diff/60001/webrtc/modules/desktop_ca...
webrtc/modules/desktop_capture/mac/full_screen_chrome_window_detector.cc:160:
for (auto it = previous_window_list_.begin();
replace this with a range loop?

https://codereview.webrtc.org/2479553006/diff/60001/webrtc/modules/desktop_ca...
File webrtc/modules/desktop_capture/mac/window_list_utils.cc (right):

https://codereview.webrtc.org/2479553006/diff/60001/webrtc/modules/desktop_ca...
webrtc/modules/desktop_capture/mac/window_list_utils.cc:19: bool
GetWindowList(DesktopCapturer::SourceList* windows) {
Style guide discourages overloaded. I don't think you really need this version
of GetWindowList().

https://codereview.webrtc.org/2479553006/diff/60001/webrtc/modules/desktop_ca...
webrtc/modules/desktop_capture/mac/window_list_utils.cc:62:
!IsWindowFullScreen(desktop_config, window)) { continue; }
Please move continue to a separate line.

[Hzj_jie, 2016-11-07 21:36:26]

Patchset #2 (id:80001) has been deleted

[Hzj_jie, 2016-11-07 23:00:18]

https://codereview.webrtc.org/2479553006/diff/60001/webrtc/modules/desktop_ca...
File webrtc/modules/desktop_capture/mac/full_screen_chrome_window_detector.cc
(right):

https://codereview.webrtc.org/2479553006/diff/60001/webrtc/modules/desktop_ca...
webrtc/modules/desktop_capture/mac/full_screen_chrome_window_detector.cc:160:
for (auto it = previous_window_list_.begin();
On 2016/11/07 20:20:56, Sergey Ulanov wrote:
> replace this with a range loop?

Done.

https://codereview.webrtc.org/2479553006/diff/60001/webrtc/modules/desktop_ca...
File webrtc/modules/desktop_capture/mac/window_list_utils.cc (right):

https://codereview.webrtc.org/2479553006/diff/60001/webrtc/modules/desktop_ca...
webrtc/modules/desktop_capture/mac/window_list_utils.cc:19: bool
GetWindowList(DesktopCapturer::SourceList* windows) {
On 2016/11/07 20:20:56, Sergey Ulanov wrote:
> Style guide discourages overloaded. I don't think you really need this version
> of GetWindowList().

Done.

https://codereview.webrtc.org/2479553006/diff/60001/webrtc/modules/desktop_ca...
webrtc/modules/desktop_capture/mac/window_list_utils.cc:62:
!IsWindowFullScreen(desktop_config, window)) { continue; }
On 2016/11/07 20:20:56, Sergey Ulanov wrote:
> Please move continue to a separate line.

Done.

[Hzj_jie, 2016-11-07 23:04:52]

The CQ bit was checked by zijiehe@chromium.org

[Hzj_jie, 2016-11-07 23:04:52]

The patchset sent to the CQ was uploaded after l-g-t-m from sergeyu@chromium.org
Link to the patchset: https://codereview.webrtc.org/2479553006/#ps100001 (title:
"Resolve review comments")

[commit-bot: I haz the power, 2016-11-07 23:05:00]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-11-07 23:25:20]

Description was changed from

==========
Implement and use new DesktopCapturer APIs in WebRTC

This change replaces all GetWindowList / GetScreenList with GetScreenList,
SelectWindow / SelectScreen with SelectSource, and BringSelectedWindowToFront
with FocusOnSelectedSource in WebRTC.

BUG=webrtc:6513
==========

to

==========
Implement and use new DesktopCapturer APIs in WebRTC

This change replaces all GetWindowList / GetScreenList with GetScreenList,
SelectWindow / SelectScreen with SelectSource, and BringSelectedWindowToFront
with FocusOnSelectedSource in WebRTC.

BUG=webrtc:6513
==========

[commit-bot: I haz the power, 2016-11-07 23:25:21]

Committed patchset #2 (id:100001)

[commit-bot: I haz the power, 2016-11-07 23:25:28]

Description was changed from

==========
Implement and use new DesktopCapturer APIs in WebRTC

This change replaces all GetWindowList / GetScreenList with GetScreenList,
SelectWindow / SelectScreen with SelectSource, and BringSelectedWindowToFront
with FocusOnSelectedSource in WebRTC.

BUG=webrtc:6513
==========

to

==========
Implement and use new DesktopCapturer APIs in WebRTC

This change replaces all GetWindowList / GetScreenList with GetScreenList,
SelectWindow / SelectScreen with SelectSource, and BringSelectedWindowToFront
with FocusOnSelectedSource in WebRTC.

BUG=webrtc:6513

Committed: https://crrev.com/fce4905987d650a3119b1071d42166c8d430d4d3
Cr-Commit-Position: refs/heads/master@{#14960}
==========

[commit-bot: I haz the power, 2016-11-07 23:25:29]

Patchset 2 (id:??) landed as
https://crrev.com/fce4905987d650a3119b1071d42166c8d430d4d3
Cr-Commit-Position: refs/heads/master@{#14960}