Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Issue 2479383003: Remove audio from BitrateEstimatorTest. (Closed)

Created:
4 years, 1 month ago by aleloi
Modified:
4 years, 1 month ago
Reviewers:
stefan-webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, the sun, stefan-webrtc, mflodman
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Remove audio from BitrateEstimatorTest. The BitrateEstimatorTest contains code to initialize an AudioState instance and an AudioReceiveStream. That code is never run, and is deleted in this CL. NOTRY=True BUG=webrtc:6346 Committed: https://crrev.com/5d78e8d96e6fcc5bec123bc9b860a10477282870 Cr-Commit-Position: refs/heads/master@{#14971}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -52 lines) Patch
M webrtc/call/bitrate_estimator_tests.cc View 12 chunks +24 lines, -52 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
aleloi
Hi! I've removed the audio parts from BitRateEstimatorTest. Can you take a look?
4 years, 1 month ago (2016-11-08 10:21:00 UTC) #2
stefan-webrtc
lgtm
4 years, 1 month ago (2016-11-08 10:45:07 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2479383003/1
4 years, 1 month ago (2016-11-08 11:41:23 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-08 11:44:57 UTC) #8
commit-bot: I haz the power
4 years, 1 month ago (2016-11-08 11:45:04 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5d78e8d96e6fcc5bec123bc9b860a10477282870
Cr-Commit-Position: refs/heads/master@{#14971}

Powered by Google App Engine
This is Rietveld 408576698