Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2479193002:
Finish reformatting RTCPUtility::RTCPParserV2::Validate() (Closed)
|
Created:
4 years, 1 month ago by Raphael Kubo da Costa (rakuco) Modified:
4 years, 1 month ago CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, zhuangzesen_agora.io, danilchap, stefan-webrtc, mflodman Target Ref:
refs/pending/heads/master Project:
webrtc Visibility:
Public. |
DescriptionFinish reformatting RTCPUtility::RTCPParserV2::Validate()
Half of the function's code was reformatted and reindented in
https://codereview.webrtc.org/1307663004, but the bottom half was still
adhering to an old coding style and using different indentation values.
Not only does this make the code look confusing, but it can cause build
issues on certain compilers: for example, GCC 6.2.0 with -Wall causes
the build to fail because -Wmisleading-indentation is enabled.
BUG=None
R=asapersson@webrtc.org,danilchap@webrtc.org
Committed: https://crrev.com/ec7b0097520add02d9b48faef43a9eaf2c4304c0
Cr-Commit-Position: refs/heads/master@{#14957}
Patch Set 1 #
Messages
Total messages: 20 (10 generated)
PTAL.
lgtm
The CQ bit was checked by raphael.kubo.da.costa@intel.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: presubmit on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/9872)
Description was changed from ========== Finish reformatting RTCPUtility::RTCPParserV2::Validate() Half of the function's code was reformatted and reindented in https://codereview.webrtc.org/1307663004, but the bottom half was still adhering to an old coding style and using different indentation values. Not only does this make the code look confusing, but it can cause build issues on certain compilers: for example, GCC 6.2.0 with -Wall causes the build to fail because -Wmisleading-indentation is enabled. R=asapersson@webrtc.org,danilchap@webrtc.org ========== to ========== Finish reformatting RTCPUtility::RTCPParserV2::Validate() Half of the function's code was reformatted and reindented in https://codereview.webrtc.org/1307663004, but the bottom half was still adhering to an old coding style and using different indentation values. Not only does this make the code look confusing, but it can cause build issues on certain compilers: for example, GCC 6.2.0 with -Wall causes the build to fail because -Wmisleading-indentation is enabled. BUG=None R=asapersson@webrtc.org,danilchap@webrtc.org ==========
The CQ bit was checked by raphael.kubo.da.costa@intel.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
The CQ bit was unchecked by raphael.kubo.da.costa@intel.com
The CQ bit was checked by raphael.kubo.da.costa@intel.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_x64_dbg on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/win_x64_dbg/builds/2886)
The CQ bit was checked by danilchap@webrtc.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
Message was sent while issue was closed.
Description was changed from ========== Finish reformatting RTCPUtility::RTCPParserV2::Validate() Half of the function's code was reformatted and reindented in https://codereview.webrtc.org/1307663004, but the bottom half was still adhering to an old coding style and using different indentation values. Not only does this make the code look confusing, but it can cause build issues on certain compilers: for example, GCC 6.2.0 with -Wall causes the build to fail because -Wmisleading-indentation is enabled. BUG=None R=asapersson@webrtc.org,danilchap@webrtc.org ========== to ========== Finish reformatting RTCPUtility::RTCPParserV2::Validate() Half of the function's code was reformatted and reindented in https://codereview.webrtc.org/1307663004, but the bottom half was still adhering to an old coding style and using different indentation values. Not only does this make the code look confusing, but it can cause build issues on certain compilers: for example, GCC 6.2.0 with -Wall causes the build to fail because -Wmisleading-indentation is enabled. BUG=None R=asapersson@webrtc.org,danilchap@webrtc.org ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Finish reformatting RTCPUtility::RTCPParserV2::Validate() Half of the function's code was reformatted and reindented in https://codereview.webrtc.org/1307663004, but the bottom half was still adhering to an old coding style and using different indentation values. Not only does this make the code look confusing, but it can cause build issues on certain compilers: for example, GCC 6.2.0 with -Wall causes the build to fail because -Wmisleading-indentation is enabled. BUG=None R=asapersson@webrtc.org,danilchap@webrtc.org ========== to ========== Finish reformatting RTCPUtility::RTCPParserV2::Validate() Half of the function's code was reformatted and reindented in https://codereview.webrtc.org/1307663004, but the bottom half was still adhering to an old coding style and using different indentation values. Not only does this make the code look confusing, but it can cause build issues on certain compilers: for example, GCC 6.2.0 with -Wall causes the build to fail because -Wmisleading-indentation is enabled. BUG=None R=asapersson@webrtc.org,danilchap@webrtc.org Committed: https://crrev.com/ec7b0097520add02d9b48faef43a9eaf2c4304c0 Cr-Commit-Position: refs/heads/master@{#14957} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/ec7b0097520add02d9b48faef43a9eaf2c4304c0 Cr-Commit-Position: refs/heads/master@{#14957} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
