Rename media constraints model and store.

Rename media constraints model and store.

ARDMediaConstraintsModel -> ARDSettingsModel
ARDMediaConstraintsSettingsStore -> ARDSettingsStore
ARDMediaConstraintsModelTests -> ARDSettingsModelTests

Both classes will be used to storing other settings as well, so we need a
more appropriate naming.

BUG=webrtc:6654
Committed: https://crrev.com/2256e04fa8302279d76d276e7da3cef7712f6eb2
Cr-Commit-Position: refs/heads/master@{#15002}

[daniela-webrtc, 2016-11-07 12:59:53]

Description was changed from

==========
Rename media constraints model and store.

Both classes will be used to storing other settings as well, so we need a
more appropriate naming.

BUG=webrtc:6654
==========

to

==========
Rename media constraints model and store.

ARDMediaConstraintsModel -> ARDSettingsModel
ARDMediaConstraintsSettingsStore -> ARDSettingsStore
ARDMediaConstraintsModelTests -> ARDSettingsModelTests

Both classes will be used to storing other settings as well, so we need a
more appropriate naming.

BUG=webrtc:6654
==========

[daniela-webrtc, 2016-11-07 12:59:53]

denicija@webrtc.org changed reviewers:
+ kthelgason@webrtc.org, magjed@webrtc.org

[kthelgason, 2016-11-07 13:31:24]

lgtm with one comment. Not sure if relevant.

https://codereview.webrtc.org/2479153002/diff/1/webrtc/examples/BUILD.gn
File webrtc/examples/BUILD.gn (right):

https://codereview.webrtc.org/2479153002/diff/1/webrtc/examples/BUILD.gn#newc...
webrtc/examples/BUILD.gn:244:
"objc/AppRTCMobile/ios/ARDSettingsModel+Private.h",
why was this not needed before? Is this perhaps unused?

[magjed_webrtc, 2016-11-07 13:47:32]

https://codereview.webrtc.org/2479153002/diff/1/webrtc/examples/objc/AppRTCMo...
File webrtc/examples/objc/AppRTCMobile/ios/ARDSettingsModel.m (right):

https://codereview.webrtc.org/2479153002/diff/1/webrtc/examples/objc/AppRTCMo...
webrtc/examples/objc/AppRTCMobile/ios/ARDSettingsModel.m:22: NSNumber
*_maximumBitrate;
Don't include this unrelated change in this CL.

[daniela-webrtc, 2016-11-07 14:45:39]

https://codereview.webrtc.org/2479153002/diff/1/webrtc/examples/BUILD.gn
File webrtc/examples/BUILD.gn (right):

https://codereview.webrtc.org/2479153002/diff/1/webrtc/examples/BUILD.gn#newc...
webrtc/examples/BUILD.gn:244:
"objc/AppRTCMobile/ios/ARDSettingsModel+Private.h",
On 2016/11/07 13:31:24, kthelgason wrote:
> why was this not needed before? Is this perhaps unused?

It was used. It worked even without being added in the BUILD file. I decided to
explicitly add it this time to be consistent with the other header files.

https://codereview.webrtc.org/2479153002/diff/1/webrtc/examples/objc/AppRTCMo...
File webrtc/examples/objc/AppRTCMobile/ios/ARDSettingsModel.m (right):

https://codereview.webrtc.org/2479153002/diff/1/webrtc/examples/objc/AppRTCMo...
webrtc/examples/objc/AppRTCMobile/ios/ARDSettingsModel.m:22: NSNumber
*_maximumBitrate;
On 2016/11/07 13:47:32, magjed_webrtc wrote:
> Don't include this unrelated change in this CL.

It got away :) Thanks!

[daniela-webrtc, 2016-11-09 10:39:01]

The CQ bit was checked by denicija@webrtc.org

[daniela-webrtc, 2016-11-09 10:39:02]

The patchset sent to the CQ was uploaded after l-g-t-m from
kthelgason@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2479153002/#ps20001 (title:
"Remove unused ivar")

[commit-bot: I haz the power, 2016-11-09 10:39:12]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[magjed_webrtc, 2016-11-09 10:41:01]

lgtm

[commit-bot: I haz the power, 2016-11-09 10:47:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-09 10:47:42]

Try jobs failed on following builders:
  win_x64_dbg on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/win_x64_dbg/builds/2964)

[daniela-webrtc, 2016-11-09 12:41:28]

The CQ bit was checked by denicija@webrtc.org

[commit-bot: I haz the power, 2016-11-09 12:41:37]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-11-09 12:43:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-09 12:43:47]

Try jobs failed on following builders:
  presubmit on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/9972)

[daniela-webrtc, 2016-11-09 13:38:20]

The CQ bit was checked by denicija@webrtc.org

[commit-bot: I haz the power, 2016-11-09 13:38:24]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-11-09 13:40:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-09 13:40:35]

Try jobs failed on following builders:
  presubmit on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/9979)

[daniela-webrtc, 2016-11-09 14:01:52]

The CQ bit was checked by denicija@webrtc.org

[daniela-webrtc, 2016-11-09 14:01:52]

The patchset sent to the CQ was uploaded after l-g-t-m from magjed@webrtc.org,
kthelgason@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2479153002/#ps40001 (title:
"Rebase master")

[commit-bot: I haz the power, 2016-11-09 14:02:03]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-11-09 14:26:20]

Description was changed from

==========
Rename media constraints model and store.

ARDMediaConstraintsModel -> ARDSettingsModel
ARDMediaConstraintsSettingsStore -> ARDSettingsStore
ARDMediaConstraintsModelTests -> ARDSettingsModelTests

Both classes will be used to storing other settings as well, so we need a
more appropriate naming.

BUG=webrtc:6654
==========

to

==========
Rename media constraints model and store.

ARDMediaConstraintsModel -> ARDSettingsModel
ARDMediaConstraintsSettingsStore -> ARDSettingsStore
ARDMediaConstraintsModelTests -> ARDSettingsModelTests

Both classes will be used to storing other settings as well, so we need a
more appropriate naming.

BUG=webrtc:6654
==========

[commit-bot: I haz the power, 2016-11-09 14:26:22]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-11-09 14:26:28]

Description was changed from

==========
Rename media constraints model and store.

ARDMediaConstraintsModel -> ARDSettingsModel
ARDMediaConstraintsSettingsStore -> ARDSettingsStore
ARDMediaConstraintsModelTests -> ARDSettingsModelTests

Both classes will be used to storing other settings as well, so we need a
more appropriate naming.

BUG=webrtc:6654
==========

to

==========
Rename media constraints model and store.

ARDMediaConstraintsModel -> ARDSettingsModel
ARDMediaConstraintsSettingsStore -> ARDSettingsStore
ARDMediaConstraintsModelTests -> ARDSettingsModelTests

Both classes will be used to storing other settings as well, so we need a
more appropriate naming.

BUG=webrtc:6654

Committed: https://crrev.com/2256e04fa8302279d76d276e7da3cef7712f6eb2
Cr-Commit-Position: refs/heads/master@{#15002}
==========

[commit-bot: I haz the power, 2016-11-09 14:26:29]

Patchset 3 (id:??) landed as
https://crrev.com/2256e04fa8302279d76d276e7da3cef7712f6eb2
Cr-Commit-Position: refs/heads/master@{#15002}