Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(71)

Issue 2477923002: Add more tests for H264 profile level id parsing (Closed)

Created:
4 years, 1 month ago by magjed_webrtc
Modified:
4 years, 1 month ago
Reviewers:
hta-webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Add more tests for H264 profile level id parsing This CL is a follow-up to https://codereview.webrtc.org/2472693002/. This CL also makes sure we consistently use lower case letters in the to-string function. BUG=webrtc:6337 Committed: https://crrev.com/f236033576199484ee93f9a2c512577179f82078 Cr-Commit-Position: refs/heads/master@{#14932}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -4 lines) Patch
M webrtc/common_video/h264/profile_level_id.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M webrtc/common_video/h264/profile_level_id_unittest.cc View 2 chunks +11 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
magjed_webrtc
Harald - please take a look.
4 years, 1 month ago (2016-11-03 21:43:36 UTC) #3
hta-webrtc
lgtm Nice to see that more tests = more consistency :-)
4 years, 1 month ago (2016-11-04 08:42:04 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2477923002/1
4 years, 1 month ago (2016-11-04 13:14:57 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-04 13:25:34 UTC) #8
commit-bot: I haz the power
4 years, 1 month ago (2016-11-04 13:25:44 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f236033576199484ee93f9a2c512577179f82078
Cr-Commit-Position: refs/heads/master@{#14932}

Powered by Google App Engine
This is Rietveld 408576698