Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(663)

Issue 2477773002: Revert of move deprected functions from EncodedImageCallback and RtpRtcp (Closed)

Created:
4 years, 1 month ago by ehmaldonado_webrtc
Modified:
4 years, 1 month ago
CC:
webrtc-reviews_webrtc.org, interface-changes_webrtc.org, video-team_agora.io, danilchap, yujie_mao (webrtc), zhuangzesen_agora.io, zhengzhonghou_agora.io, stefan-webrtc, tterriberry_mozilla.com, qiang.lu, niklas.enbom, peah-webrtc, perkj_webrtc, mflodman
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of move deprected functions from EncodedImageCallback and RtpRtcp (patchset #1 id:1 of https://codereview.webrtc.org/2467373003/ ) Reason for revert: Made a mistake while reverting. Original issue's description: > Reland of move deprected functions from EncodedImageCallback and RtpRtcp (patchset #2 id:240001 of https://codereview.webrtc.org/2474433008/ ) > > Reason for revert: > Breaks everything > > Original issue's description: > > Revert of Remove deprected functions from EncodedImageCallback and RtpRtcp (patchset #4 id:100001 of https://codereview.webrtc.org/2405173006/ ) > > > > Reason for revert: > > This might be breaking projects downstream. > > > > Original issue's description: > > > Remove deprected functions from EncodedImageCallback and RtpRtcp > > > > > > Removed EncodedImageCallback::Encoded() and RtpRtcp::SendOutgoingData(). > > > These methods should no longer be used anywhere and it's safe to remove > > > them. > > > > > > BUG=chromium:621691 > > > > > > Committed: https://crrev.com/fa565842718ad178a7562721b25d916fbabc2b92 > > > Cr-Commit-Position: refs/heads/master@{#14902} > > > > TBR=mflodman@webrtc.org,stefan@webrtc.org,sergeyu@chromium.org > > # Skipping CQ checks because original CL landed less than 1 days ago. > > NOPRESUBMIT=true > > NOTREECHECKS=true > > NOTRY=true > > BUG=chromium:621691 > > > > Committed: https://crrev.com/6c78307a21252c2dbd704f6d5e92a220fb722ed4 > > Cr-Commit-Position: refs/heads/master@{#14914} > > TBR=mflodman@webrtc.org,stefan@webrtc.org,sergeyu@chromium.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=chromium:621691 > > Committed: https://crrev.com/a1d6cd64083a3c0173aeefe38425a56de8942745 > Cr-Commit-Position: refs/heads/master@{#14915} TBR=mflodman@webrtc.org,stefan@webrtc.org,sergeyu@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:621691 Committed: https://crrev.com/43a9dc0f93e1c8c822c55bcb89b9f0f746354651 Cr-Commit-Position: refs/heads/master@{#14916}

Patch Set 1 #

Patch Set 2 : Silly mistake in webrtc/test/fake_encoder.cc #

Unified diffs Side-by-side diffs Delta from patch set Stats (+74 lines, -64 lines) Patch
M webrtc/api/android/jni/androidmediaencoder_jni.cc View 1 4 chunks +8 lines, -7 lines 0 comments Download
M webrtc/modules/rtp_rtcp/include/rtp_rtcp.h View 1 2 chunks +19 lines, -0 lines 0 comments Download
M webrtc/modules/video_coding/codecs/h264/h264_encoder_impl.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/modules/video_coding/codecs/h264/h264_video_toolbox_encoder.mm View 1 1 chunk +3 lines, -4 lines 0 comments Download
M webrtc/modules/video_coding/codecs/i420/i420.cc View 1 1 chunk +1 line, -2 lines 0 comments Download
M webrtc/modules/video_coding/codecs/vp8/simulcast_encoder_adapter_unittest.cc View 1 1 chunk +3 lines, -3 lines 0 comments Download
M webrtc/modules/video_coding/codecs/vp8/vp8_impl.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/modules/video_coding/codecs/vp9/vp9_impl.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/modules/video_coding/video_receiver.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/test/configurable_frame_size_encoder.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M webrtc/test/fake_encoder.cc View 1 1 chunk +1 line, -3 lines 0 comments Download
M webrtc/video/payload_router_unittest.cc View 1 7 chunks +8 lines, -24 lines 0 comments Download
M webrtc/video/video_send_stream_tests.cc View 1 1 chunk +1 line, -3 lines 0 comments Download
M webrtc/video/vie_encoder_unittest.cc View 1 1 chunk +4 lines, -5 lines 0 comments Download
M webrtc/video_encoder.h View 1 1 chunk +17 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
ehmaldonado_webrtc
Created Revert of move deprected functions from EncodedImageCallback and RtpRtcp
4 years, 1 month ago (2016-11-03 14:43:09 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2477773002/280001
4 years, 1 month ago (2016-11-03 14:52:24 UTC) #3
commit-bot: I haz the power
Committed patchset #2 (id:280001)
4 years, 1 month ago (2016-11-03 14:52:39 UTC) #4
commit-bot: I haz the power
4 years, 1 month ago (2016-11-03 14:52:50 UTC) #6
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/43a9dc0f93e1c8c822c55bcb89b9f0f746354651
Cr-Commit-Position: refs/heads/master@{#14916}

Powered by Google App Engine
This is Rietveld 408576698