Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(183)

Issue 2477693002: Remove webrtc/base/buffer.cc, now that Chromium doesn't claim to need it anymore (Closed)

Created:
4 years, 1 month ago by kwiberg-webrtc
Modified:
4 years, 1 month ago
Reviewers:
ossu
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Remove webrtc/base/buffer.cc, now that Chromium doesn't claim to need it anymore BUG=webrtc:5845 Committed: https://crrev.com/9189793d69610d957ee02d79f310016ee454e56a Cr-Commit-Position: refs/heads/master@{#14913}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -12 lines) Patch
D webrtc/base/buffer.cc View 1 chunk +0 lines, -12 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
kwiberg-webrtc
4 years, 1 month ago (2016-11-03 13:16:13 UTC) #2
kwiberg-webrtc
4 years, 1 month ago (2016-11-03 13:16:14 UTC) #3
ossu
lgtm, but what's changed that chromium doesn't need this anymore? gyp -> gn?
4 years, 1 month ago (2016-11-03 13:52:33 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2477693002/1
4 years, 1 month ago (2016-11-03 13:53:44 UTC) #6
kwiberg-webrtc
On 2016/11/03 13:52:33, ossu wrote: > lgtm, but what's changed that chromium doesn't need this ...
4 years, 1 month ago (2016-11-03 13:54:41 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-03 14:04:21 UTC) #8
commit-bot: I haz the power
4 years, 1 month ago (2016-11-03 14:04:34 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9189793d69610d957ee02d79f310016ee454e56a
Cr-Commit-Position: refs/heads/master@{#14913}

Powered by Google App Engine
This is Rietveld 408576698