Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(567)

Issue 2477663002: Disabling NOTREACHED which we're hitting flakily in browser tests. (Closed)

Created:
4 years, 1 month ago by phoglund
Modified:
4 years, 1 month ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, zhengzhonghou_agora.io, video-team_agora.io, mflodman
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Disabling NOTREACHED which we're hitting flakily in browser tests. I have no idea how bad it is that we're hitting this limit; I'm just doing this to stop the tests from flaking. BUG=webrtc:6484 Committed: https://crrev.com/6eaa55867b449df992752c1df540ec42f9d9b057 Cr-Commit-Position: refs/heads/master@{#14974}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M webrtc/modules/video_coding/codecs/vp9/vp9_frame_buffer_pool.cc View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 24 (8 generated)
phoglund
4 years, 1 month ago (2016-11-03 10:59:39 UTC) #2
phoglund
4 years, 1 month ago (2016-11-03 11:00:41 UTC) #4
åsapersson
lgtm
4 years, 1 month ago (2016-11-03 12:17:53 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2477663002/1
4 years, 1 month ago (2016-11-03 12:57:30 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: presubmit on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/9788)
4 years, 1 month ago (2016-11-03 13:00:20 UTC) #9
phoglund
Stefan, owner stamp please?
4 years, 1 month ago (2016-11-03 13:29:33 UTC) #10
stefan-webrtc
lgtm, although hopefully this has already been fixed.
4 years, 1 month ago (2016-11-08 08:54:55 UTC) #11
phoglund
It has not, so I'm landing this now.
4 years, 1 month ago (2016-11-08 09:17:36 UTC) #12
phoglund
On 2016/11/08 09:17:36, phoglund wrote: > It has not, so I'm landing this now. Recent ...
4 years, 1 month ago (2016-11-08 09:18:21 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2477663002/1
4 years, 1 month ago (2016-11-08 09:18:29 UTC) #15
phoglund
On 2016/11/08 09:18:29, commit-bot: I haz the power wrote: > CQ is trying da patch. ...
4 years, 1 month ago (2016-11-08 09:21:09 UTC) #17
phoglund
On 2016/11/08 09:21:09, phoglund wrote: > On 2016/11/08 09:18:29, commit-bot: I haz the power wrote: ...
4 years, 1 month ago (2016-11-08 13:30:14 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2477663002/1
4 years, 1 month ago (2016-11-08 13:30:38 UTC) #20
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-08 13:32:07 UTC) #21
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/6eaa55867b449df992752c1df540ec42f9d9b057 Cr-Commit-Position: refs/heads/master@{#14974}
4 years, 1 month ago (2016-11-08 13:32:16 UTC) #23
åsapersson
4 years ago (2016-12-19 07:30:32 UTC) #24
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.webrtc.org/2585183002/ by asapersson@webrtc.org.

The reason for reverting is: To see if the NOTREACHED is still hit..

Powered by Google App Engine
This is Rietveld 408576698