|
|
DescriptionDisabling NOTREACHED which we're hitting flakily in browser tests.
I have no idea how bad it is that we're hitting this limit; I'm just
doing this to stop the tests from flaking.
BUG=webrtc:6484
Committed: https://crrev.com/6eaa55867b449df992752c1df540ec42f9d9b057
Cr-Commit-Position: refs/heads/master@{#14974}
Patch Set 1 #
Messages
Total messages: 24 (8 generated)
phoglund@webrtc.org changed reviewers: + asapersson@webrtc.org
phoglund@webrtc.org changed reviewers: + stefan@webrtc.org
lgtm
The CQ bit was checked by phoglund@webrtc.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: presubmit on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/9788)
Stefan, owner stamp please?
lgtm, although hopefully this has already been fixed.
It has not, so I'm landing this now.
On 2016/11/08 09:17:36, phoglund wrote: > It has not, so I'm landing this now. Recent example, which happened after the libvpx roll: https://build.chromium.org/p/chromium.webrtc.fyi/builders/Win10%20Tester/buil...
The CQ bit was checked by phoglund@webrtc.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
The CQ bit was unchecked by phoglund@webrtc.org
On 2016/11/08 09:18:29, commit-bot: I haz the power wrote: > CQ is trying da patch. Follow status at > > https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/... Or wait actually, that build was from yesterday. Let me investigate a bit more...
On 2016/11/08 09:21:09, phoglund wrote: > On 2016/11/08 09:18:29, commit-bot: I haz the power wrote: > > CQ is trying da patch. Follow status at > > > > > https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/... > > Or wait actually, that build was from yesterday. Let me investigate a bit > more... Nope, https://build.chromium.org/p/chromium.webrtc/builders/Win10%20Tester/builds/1... failed very recently, so I'm submitting this.
The CQ bit was checked by phoglund@webrtc.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Disabling NOTREACHED which we're hitting flakily in browser tests. I have no idea how bad it is that we're hitting this limit; I'm just doing this to stop the tests from flaking. BUG=webrtc:6484 ========== to ========== Disabling NOTREACHED which we're hitting flakily in browser tests. I have no idea how bad it is that we're hitting this limit; I'm just doing this to stop the tests from flaking. BUG=webrtc:6484 Committed: https://crrev.com/6eaa55867b449df992752c1df540ec42f9d9b057 Cr-Commit-Position: refs/heads/master@{#14974} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/6eaa55867b449df992752c1df540ec42f9d9b057 Cr-Commit-Position: refs/heads/master@{#14974}
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in https://codereview.webrtc.org/2585183002/ by asapersson@webrtc.org. The reason for reverting is: To see if the NOTREACHED is still hit.. |