Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(133)

Issue 2477343002: H264SpsPpsTracker now return PacketAction on CopyAndFixBitstream. (Closed)

Created:
4 years, 1 month ago by philipel
Modified:
4 years, 1 month ago
Reviewers:
stefan-webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, zhengzhonghou_agora.io, video-team_agora.io, stefan-webrtc, mflodman
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

H264SpsPpsTracker now return PacketAction on CopyAndFixBitstream. To differentiate between when a packet should be dropped or when a keyframe is missing its SPS and/or SPS CopyAndFixBitstream now returns: - kInsert, the packet should be inserted into the PacketBuffer. - kDrop, the packet should be dropped. - kRequestKeyframe, a keyframe should be requested. BUG=webrtc:5514 Committed: https://crrev.com/a75d12d09d5f9fdb4a14253ac2533fc7ab22d710 Cr-Commit-Position: refs/heads/master@{#14948}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -19 lines) Patch
M webrtc/modules/video_coding/h264_sps_pps_tracker.h View 1 chunk +3 lines, -1 line 0 comments Download
M webrtc/modules/video_coding/h264_sps_pps_tracker.cc View 5 chunks +8 lines, -7 lines 0 comments Download
M webrtc/modules/video_coding/h264_sps_pps_tracker_unittest.cc View 11 chunks +16 lines, -11 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
philipel
4 years, 1 month ago (2016-11-07 12:36:55 UTC) #2
stefan-webrtc
lgtm
4 years, 1 month ago (2016-11-07 12:38:37 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2477343002/1
4 years, 1 month ago (2016-11-07 12:42:24 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-07 13:11:35 UTC) #6
commit-bot: I haz the power
4 years, 1 month ago (2016-11-07 13:11:50 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a75d12d09d5f9fdb4a14253ac2533fc7ab22d710
Cr-Commit-Position: refs/heads/master@{#14948}

Powered by Google App Engine
This is Rietveld 408576698