Allocate extra buffer space in FrameObject in case of H264.

Allocate extra buffer space in FrameObject in case of H264.

Since ffmpeg use an optimized bitstream reader that reads in chunks of 32/64
bits the bitstream buffer has to be increased in order for the reader to not
read out of bounds.

BUG=webrtc:5514
R=stefan@webrtc.org

Committed: https://chromium.googlesource.com/external/webrtc/+/36928454fab7078ae1d867b5abda1bb1e2e7685b

[philipel, 2016-11-03 12:19:12]

philipel@webrtc.org changed reviewers:
+ brandtr@webrtc.org, stefan@webrtc.org

[stefan-webrtc, 2016-11-03 13:04:02]

lgtm, but please reconsider... :)

https://codereview.webrtc.org/2476513004/diff/20001/webrtc/modules/video_codi...
File webrtc/modules/video_coding/video_packet_buffer_unittest.cc (right):

https://codereview.webrtc.org/2476513004/diff/20001/webrtc/modules/video_codi...
webrtc/modules/video_coding/video_packet_buffer_unittest.cc:358: "    
:YYiii$$$$$$$YYYYYYY$$$$YY$$$$YYiiiiiYYYYYYi'";
While it's fun, maybe it's not worth spending 10 lines of code on? :)

[philipel, 2016-11-03 13:28:07]

The CQ bit was checked by philipel@webrtc.org

[philipel, 2016-11-03 13:28:08]

The patchset sent to the CQ was uploaded after l-g-t-m from stefan@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2476513004/#ps40001 (title:
"No Doge")

[commit-bot: I haz the power, 2016-11-03 13:28:13]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-11-03 13:37:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-03 13:37:05]

Try jobs failed on following builders:
  win_baremetal on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/win_baremetal/builds/15738)

[philipel, 2016-11-03 14:15:53]

The CQ bit was checked by philipel@webrtc.org

[philipel, 2016-11-03 14:15:53]

The patchset sent to the CQ was uploaded after l-g-t-m from stefan@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2476513004/#ps60001 (title:
"Win fix")

[commit-bot: I haz the power, 2016-11-03 14:15:56]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-11-03 14:57:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-03 14:57:31]

Try jobs failed on following builders:
  android_dbg on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/android_dbg/builds/18265)

[commit-bot: I haz the power, 2016-11-07 09:42:45]

Description was changed from

==========
Allocate extra buffer space in FrameObject in case of H264.

Since ffmpeg use an optimized bitstream reader that reads in chunks of 32/64
bits the bitstream buffer has to be increased in order for the reader to not
read out of bounds.

BUG=webrtc:5514
==========

to

==========
Allocate extra buffer space in FrameObject in case of H264.

Since ffmpeg use an optimized bitstream reader that reads in chunks of 32/64
bits the bitstream buffer has to be increased in order for the reader to not
read out of bounds.

BUG=webrtc:5514
R=stefan@webrtc.org

Committed: https://crrev.com/36928454fab7078ae1d867b5abda1bb1e2e7685b
Cr-Commit-Position: refs/heads/master@{#14941}
==========

[commit-bot: I haz the power, 2016-11-07 09:42:46]

Patchset 4 (id:??) landed as
https://crrev.com/36928454fab7078ae1d867b5abda1bb1e2e7685b
Cr-Commit-Position: refs/heads/master@{#14941}

[philipel, 2016-11-07 09:42:47]

Description was changed from

==========
Allocate extra buffer space in FrameObject in case of H264.

Since ffmpeg use an optimized bitstream reader that reads in chunks of 32/64
bits the bitstream buffer has to be increased in order for the reader to not
read out of bounds.

BUG=webrtc:5514
R=stefan@webrtc.org

Committed: https://crrev.com/36928454fab7078ae1d867b5abda1bb1e2e7685b
Cr-Commit-Position: refs/heads/master@{#14941}
==========

to

==========
Allocate extra buffer space in FrameObject in case of H264.

Since ffmpeg use an optimized bitstream reader that reads in chunks of 32/64
bits the bitstream buffer has to be increased in order for the reader to not
read out of bounds.

BUG=webrtc:5514
R=stefan@webrtc.org

Committed:
https://chromium.googlesource.com/external/webrtc/+/36928454fab7078ae1d867b5a...
==========

[philipel, 2016-11-07 09:42:48]

Committed patchset #4 (id:60001) manually as
36928454fab7078ae1d867b5abda1bb1e2e7685b (presubmit successful).