Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(723)

Issue 2476353006: Remove cyclic dependency in gyp build (Closed)

Created:
4 years, 1 month ago by kthelgason
Modified:
4 years, 1 month ago
Reviewers:
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Remove cyclic dependency in gyp build NOTRY=true NOPRESUBMIT=true BUG=None TBR=magjed@webrtc.org Committed: https://crrev.com/faa7689adbf35136f0939d13bfa274c2ad0f5321 Cr-Commit-Position: refs/heads/master@{#14994}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -3 lines) Patch
M webrtc/sdk/sdk.gyp View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (5 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2476353006/1
4 years, 1 month ago (2016-11-09 10:07:08 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-09 10:07:15 UTC) #6
commit-bot: I haz the power
4 years, 1 month ago (2016-11-09 10:07:25 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/faa7689adbf35136f0939d13bfa274c2ad0f5321
Cr-Commit-Position: refs/heads/master@{#14994}

Powered by Google App Engine
This is Rietveld 408576698